New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI settings: Add option to disable logging to files #12948
Comments
*I think logs should stay on by default. |
It is probably too late, but #9805 doesn't make sense. The issue refers to https://www.privacyaffairs.com/cve-2021-22929-brave-tor-vulnerability/ that says:
Do we really think that the user should be afraid of the Logs when an attacker has access to their device?
☝👍 |
Personally, I don't think it's worthy of a UI settings change, I just reported it.
It would make more sense if the rest was encrypted. Like #6670 would be more valuable (to us) to fix, if we are talking about logs. |
@BTCparadigm asked me to open this issue.
Description
The goal is to add to the UI settings an option to specify whether logs should be stored in logging files (
Logs.txt
andTorLogs.txt
) or not. UX-wise I would expect a toggle button.We have
--LogsMode
command line option to specify which logging targets are to be used (see #12919 (comment)). So code-wise it should be reasonbly ready for adding of the new option to settings.Reasoning
This is to be considered whether we should really have it or not. The original issue mentioned as a reason:
Questions
Note that if it is on, we'll have very hard time to get logs when a user needs some support.
The text was updated successfully, but these errors were encountered: