Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename password - The ancient forgotten spell #12614

Open
5 of 7 tasks
molnard opened this issue Mar 5, 2024 · 4 comments · May be fixed by #12731
Open
5 of 7 tasks

Rename password - The ancient forgotten spell #12614

molnard opened this issue Mar 5, 2024 · 4 comments · May be fixed by #12731
Assignees
Milestone

Comments

@molnard
Copy link
Collaborator

molnard commented Mar 5, 2024

Original Quest credits @Kruwed.

📜 Preamble

Dismissing the confusion around password's role in recovering a wallet.

📖 TL;DR - Too Long, Didn't Read

Ongoing feedback received by our support team indicates that users find Wasabi's user experience unclear, particularly regarding the significance and function of passwords. This redesign initiative aims to make the user interface more intuitive by tackling two main problems. Firstly, a prevalent issue arises when users restore their wallet with a different password, resulting in a wallet showing a zero balance. Secondly, a less frequent but significant issue occurs when users forget their password and fail to back it up, under the impression that passwords are not required for wallet recovery.

🌟 Specification, Scope, and Features

Objectives:

  • Ensure the user properly records their recovery phrases and password, addressing the second issue mentioned above.
  • Ensure the user is aware of and will use the identical password during recovery, addressing the first issue mentioned above.

Exclusions:

  • Do not attempt to instruct the user on backup methods utilizing "best practices" within the software. Such guidance belongs in the documentation or blog posts, although a link within the software could be provided.
  • Avoid implementing additional dialogs or measures to persuade the user to follow "best practices" for backups. Our primary aim is to ensure the user initiates a backup; the method of doing so is beyond our purview.

⚔️ Motivation

Losing your coins is the worst UX.

📜 Rationale

  • The first user report was years ago and the zero balance wallet issue has been coming since then. I have also witnessed the confusion IRL when one of my friends tried to recover his wallet.
  • The team tried to solve this many times without success and that led to frustration and enormous energy spent on opening issues, arguments, etc. Look at the number of issues and discussions related to this below.

🌌 Backward Compatibility

The seed format is unchanged.

📚 Reference Implementation (optional)

🫂 Team involvement:

UI, UX

✅ Subtasks:

  • Create this issue as a first step.
  • Have a conversation with the support team, clarifying the problems.
  • Figuring out the directions toward the solution.
  • Consult with the UX team.
  • Create designs and demo.
  • Implementation: code and ui.
  • Make sure the legal docs are updated according to Use passphrase instead of password #12320

🧾 Resources:

@molnard molnard self-assigned this Mar 5, 2024
@MaxHillebrand MaxHillebrand changed the title The ancient forgotten spell Rename password - The ancient forgotten spell Mar 6, 2024
@MaxHillebrand MaxHillebrand added this to the v2.0.7 milestone Mar 6, 2024
@molnard
Copy link
Collaborator Author

molnard commented Mar 12, 2024

Merged: #12320

@soosr soosr assigned wieslawsoltes and unassigned danwalmsley and molnard Mar 25, 2024
@wieslawsoltes wieslawsoltes linked a pull request Mar 26, 2024 that will close this issue
12 tasks
@wieslawsoltes
Copy link
Collaborator

@molnard @lontivero so we are renaming in UI from Password to Passphrase should we also update RPC to follow same naming convention?

@wieslawsoltes
Copy link
Collaborator

@molnard @lontivero so we are renaming in UI from Password to Passphrase should we also update RPC to follow same naming convention?

Also codebase has a lot of occurences (obviously some not related but there is a lot of related):
image

@molnard
Copy link
Collaborator Author

molnard commented Mar 27, 2024

No. Just in the UI.

@soosr soosr modified the milestones: v2.0.7, v2.0.8 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀Doing
Development

Successfully merging a pull request may close this issue.

5 participants