Update Manager - Endpoint gave back wrong json data or it's changed

[soosr]

Got the following exception on this branch: #12305, 74eb67c

2024-03-07 09:36:28.854 [18] ERROR      UpdateManager.UpdateChecker_UpdateStatusChangedAsync (96)       Getting new update failed with error. Exception: System.IO.InvalidDataException: Endpoint gave back wrong json data or it's changed.
   at WalletWasabi.Services.UpdateManager.GetLatestReleaseFromGithubAsync(Version targetVersion, CancellationToken cancellationToken) in WalletWasabi\Services\UpdateManager.cs:line 195
   at WalletWasabi.Services.UpdateManager.GetInstallerAsync(Version targetVersion, CancellationToken cancellationToken) in WalletWasabi\Services\UpdateManager.cs:line 110
   at WalletWasabi.Services.UpdateManager.UpdateChecker_UpdateStatusChangedAsync(Object sender, UpdateStatus updateStatus) in WalletWasabi\Services\UpdateManager.cs:line 76
2024-03-07 09:36:29.930 [19] ERROR      UpdateManager.UpdateChecker_UpdateStatusChangedAsync (96)       Getting new update failed with error. Exception: System.IO.InvalidDataException: Endpoint gave back wrong json data or it's changed.
   at WalletWasabi.Services.UpdateManager.GetLatestReleaseFromGithubAsync(Version targetVersion, CancellationToken cancellationToken) in WalletWasabi\Services\UpdateManager.cs:line 195
   at WalletWasabi.Services.UpdateManager.GetInstallerAsync(Version targetVersion, CancellationToken cancellationToken) in WalletWasabi\Services\UpdateManager.cs:line 110
   at WalletWasabi.Services.UpdateManager.UpdateChecker_UpdateStatusChangedAsync(Object sender, UpdateStatus updateStatus) in WalletWasabi\Services\UpdateManager.cs:line 76

[Szpoti]

Can't repro.

2024-03-07 10:58:48.183 [15] INFO       UpdateManager.GetInstallerAsync (126)   Trying to download new version: 2.0.6
2024-03-07 10:58:50.101 [28] INFO       UpdateManager.GetInstallerAsync (133)   Installer downloaded, copying...
2024-03-07 10:58:50.303 [34] INFO       UpdateManager.UpdateChecker_UpdateStatusChangedAsync (78)       Version 2.0.6 downloaded successfully.

[soosr]

It doesn't happen all the time. I have encountered the issue again since I reported it.

[Szpoti]

Although I'm not 100% sure what's the real issue in the background, I can imagine that the json data was an error wrapped in HTML. It can happen from time to time when there are server side or internet issues. I remember I choose having this as an error to indicate that there is, in fact, an error in the background, the default workflow that should work has been broken. But there is nothing the user can do, other than downloading the new version manually.
So I'd say the best to do is to change the LogLevel here to Warning.

[molnard]

Now that the PR was merged, next step is to wait for the error again and observe the JSON string?

[Szpoti]

Now that the PR was merged, next step is to wait for the error again and observe the JSON string?

Yes, that way we'll know what exactly goes wrong and can handle the error correctly in the future.

[Szpoti]

Found the error, this is what we get back from the endpoint:

2024-04-18 11:58:06.103 [12] WARNING	UpdateManager.GetLatestReleaseFromGithubAsync (194)	{
  "message": "API rate limit exceeded for my.ip.address.###. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
  "documentation_url": "https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"
}

It could probably happen because we make requests very fast when getting the update.