Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About selecting demonstration when testing IKE #244

Closed
yaohui120 opened this issue Apr 29, 2024 · 2 comments
Closed

About selecting demonstration when testing IKE #244

yaohui120 opened this issue Apr 29, 2024 · 2 comments
Labels
question Further information is requested

Comments

@yaohui120
Copy link

In function apply_ike_to_multimodal_model in EasyEdit-main/easyeditor/models/ike/ike_main.py, the last line is

icl_examples.append(f'New Fact: {new_fact}\nPrompt: {new_fact}\n\n')

I'm a little confused. Why adding the question and answer of a testing sample when applying ike? My understanding is that the input of model should not contain the true answer of the testing question.

@tbozhong
Copy link
Collaborator

Thanks for your attention to our work.

It seems that you have mentioned this question before in #215, we just follow the setting of IKE. I'd suggest direct contact with the authors to seek further clarification. They may be better poised to assist you in your inquiry.

@tbozhong tbozhong added the question Further information is requested label Apr 29, 2024
@yaohui120
Copy link
Author

Thank you for your help. I'll do experiments to explore the influence.

@zxlzr zxlzr closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants