Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMTP templates. Show activate provider as another optional step #7929

Closed
2 tasks done
doncicuto opened this issue May 8, 2024 · 4 comments · Fixed by #7956
Closed
2 tasks done

SMTP templates. Show activate provider as another optional step #7929

doncicuto opened this issue May 8, 2024 · 4 comments · Fixed by #7956
Assignees
@doncicuto
Labels
improvement released resources

Comments

@doncicuto
Copy link
Contributor

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions
  • I have joined the ZITADEL chat

Describe your problem

@eliobischof suggested in Discord that it'd good if you can activate the SMTP provider in a similar way as the new IDP wizard works.

Describe your ideal solution

Here's the screenshot for a new Google IDP

image

I'd add the 'active this SMTP provider' as an optional step once you create the provider (the dialog would not be closed and this step would be shown).

I agree and I missed that option when developing SMTP templates... so I open an issue to track this feature.

Of course, feel free to assign this issue to me.

Version

No response

Environment

Self-hosted

Additional Context

No response
@doncicuto doncicuto changed the title Add the option to activate provider as another opt step SMPT SMTP templates. Show activate provider as another optiona step May 8, 2024
@doncicuto doncicuto changed the title SMTP templates. Show activate provider as another optiona step SMTP templates. Show activate provider as another optional step May 8, 2024
@eliobischof
Copy link
Member

I think especially for self-hosters without a default smtp config this feature could help a lot to avoid confusion, as in the provider list it's not obvious that a provider is inactive after creation and where it can be activated.

@hifabienne
Copy link
Member

Hi @doncicuto I think this would be nice to have. I will assign you as you suggested.

@doncicuto
Copy link
Contributor Author

Hei @hifabienne I'm starting to work on this issue right now

@doncicuto doncicuto mentioned this issue May 15, 2024
Merged
eliobischof pushed a commit that referenced this issue May 22, 2024
@doncicuto
feat(console): add new step to activate SMTP provider (#7956)
cca3421 
# Which Problems Are Solved

- In #7929 it was detected that it would be better to show the
activate/deactivate action for a SMTP configuration in the wizard as for
some users it'd not be intuitive that the SMTP provider must be
activated so Zitadel can use it to send notifications.

# How the Problems Are Solved

- When a new SMTP provider is added or updated, the wizard has a new
step that allow us to activate or deactivate the provider configured in
the previous step. The following video shows the new wizard:


https://github.com/zitadel/zitadel/assets/30386061/178234d6-73dc-4719-af0b-1d6f19bf3f7d

# Additional Context

- Closes #7929
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doncicuto doncicuto

Labels
improvement released resources
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(console): add new step to activate SMTP provider doncicuto/zitadel
3 participants
@eliobischof @doncicuto @hifabienne