Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top 5% volatility filtering location DataExploration #130

Open
vincentlin2 opened this issue Jul 31, 2023 · 1 comment
Open

Top 5% volatility filtering location DataExploration #130

vincentlin2 opened this issue Jul 31, 2023 · 1 comment

Comments

@vincentlin2
Copy link

Code in exploration/data_exploration.py

def _shift_intensity(self, change_points=None, df=None, metric=None):
        """
        This function computes the Kullback_Leibler divergence of the the time series around a changepoint detected by the
        pelt_change_point_detection() function. This considers Gaussian assumption on the underlying data distribution.

        :param list change_points: A list storing indices of the potential change points
        :param pandas.dataframe df: A pandas dataframe containing time series ignoring the top 5% volatility
        :param str metric: A string in the dataframe column names that contains the time series
        :return: A list containing the magnitude of changes for every corresponding change points
        :rtype: list
        """

Question
After looking through the code, I was wondering where the top 5% volatility dropped? It doesn't look like it's filtered anywhere before it.

Thank you for the help!

@sayanchk
Copy link
Collaborator

sayanchk commented Aug 2, 2023

@vincentlin2 This is a documentation error. Thanks for catching!

We had a logic of detecting changepoints after removing the volatilities beyond p95 which we later removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants