Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在全屏（或页面全屏）和非全屏状态切换时setting组件漂移问题 #737

Open
fbotp opened this issue Apr 7, 2024 · 1 comment · May be fixed by #740
Open

在全屏（或页面全屏）和非全屏状态切换时setting组件漂移问题 #737

fbotp opened this issue Apr 7, 2024 · 1 comment · May be fixed by #740
Labels
todo

Comments

@fbotp
Copy link

fbotp commented Apr 7, 2024

Expected behaviour

setting组件正常显示

Actual behaviour

2024-04-07.23-37-18.mov

Steps to reproduce

  • 从非全屏到全屏：
    在https://artplayer.org/中，点击setting按钮两次，使其显示后再关闭，随后点击页面全屏或全屏按钮，再次单击setting按钮，setting从左方漂移到了正确位置
  • 从全屏到非全屏：
    操作类似，先在全屏状态点击两次setting按钮，再退回非全屏状态，点击setting按钮，setting从右方漂移到了正确位置

Environment

  • Browser: Chrome
  • Version: 123.0.6312.106
  • Operating System: Windows Pro
  • Version: 22H2(19045.4239)

Console errors (if any)

Link to where the bug is happening

https://artplayer.org/
@zhw2590582
Copy link
Owner

因为设置按钮的位置是不确定的，设置面板和设置按钮也是不关联的，所以点击设置按钮的时候会计算一次它的位置，再设置面板的位置，在加上动画的延迟就会感觉面板偏移了，确实效果不太好，有待优化

@WeidiDeng WeidiDeng linked a pull request Apr 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove updateStyle WeidiDeng/ArtPlayer
2 participants
@zhw2590582 @fbotp