You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using postcss-critical-css with Webpack 4 (Windows 10) and I am facing the following issue: when importing in the same JS entrypoint several scss partials containing critical at-rules pointing to the same output file, seems like the generated css carries just the contents from one of the sources (usually the one from the last saved source file). Each at-rule overwrites the previous. Sometimes partial overwrites could happen as well, generating syntax errors in the output.
This happens for static scss imports and for dynamic imports of JS files carrying scss imports, as well.
The text was updated successfully, but these errors were encountered:
bitfella
changed the title
Each at-rule overwrite the previous pointing to the same output file (Webpack 4)
Each at-rule overwrites the previous pointing to the same output file (Webpack 4)
Oct 2, 2019
Thanks for the bug report, and repo with the replication. It does sound like there's a bug here. I'll take a look as soon as I can; PRs welcome, in the meantime. Cheers.
@zgreen thanks for your quick reply. Please be aware that @ostowe's own fork should solve this issue. I've tested it locally and everything seems to work fine. Please have a look at his PR #27 :)
Hello, I guess this could be related to #27.
I am using postcss-critical-css with Webpack 4 (Windows 10) and I am facing the following issue: when importing in the same JS entrypoint several scss partials containing critical at-rules pointing to the same output file, seems like the generated css carries just the contents from one of the sources (usually the one from the last saved source file). Each at-rule overwrites the previous. Sometimes partial overwrites could happen as well, generating syntax errors in the output.
This happens for static scss imports and for dynamic imports of JS files carrying scss imports, as well.
See this repo for further explanation.
Thanks
The text was updated successfully, but these errors were encountered: