Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.4.1 is a breaking change #116

Open
Zheoni opened this issue May 6, 2024 · 4 comments
Open

Version 0.4.1 is a breaking change #116

Zheoni opened this issue May 6, 2024 · 4 comments

Comments

@Zheoni
Copy link
Contributor

Zheoni commented May 6, 2024

It removed the ariadne::Color::Default variant, so my project fails to compile. It should be a minor release, not a patch one, because cargo will pull the new version even if I depended on 0.4.

@01mf02
Copy link
Contributor

01mf02 commented May 7, 2024

I have the same issue (see 01mf02/jaq#176 and 01mf02/jaq#178): yansi 1.0 is a breaking change compared to yansi 0.5, so because ariadne 0.4 exposes types from yansi 0.5, ariadne 0.4.1 cannot depend on yansi 1.0. A solution to this problem would be to yank the 0.4.1 release and publish a 0.5 release instead.

@01mf02
Copy link
Contributor

01mf02 commented May 15, 2024

@zesterer, may I ask you if there is any update on this? Builds of my application still break due to this issue.

@zesterer
Copy link
Owner

Argh, this is annoying. Apologies about that. Sorry, I've not had much time to focus on this of late. I'll try to get this resolved over the next few days.

@01mf02
Copy link
Contributor

01mf02 commented May 21, 2024

Thanks. Btw, to catch this kind of issues in advance, cargo semver-checks can be pretty useful. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants