Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow type definition more permissive than the actual code #27

Open
dsilvasc opened this issue Jul 20, 2017 · 2 comments · May be fixed by #48
Open

flow type definition more permissive than the actual code #27

dsilvasc opened this issue Jul 20, 2017 · 2 comments · May be fixed by #48

Comments

@dsilvasc
Copy link

The flow type definition says that the format argument is optional, but it's not. At least in dev mode, when format is missing invariant throws an error.
@turadg
Copy link

turadg commented Apr 22, 2020

PR to make the TypeScript definition require the format argument. DefinitelyTyped/DefinitelyTyped#44098

chrisbobbe added a commit to chrisbobbe/invariant that referenced this issue Dec 14, 2021
@chrisbobbe
flow types: Make format argument required, like in implementation
0aefb95 
We throw an error when `format` is missing.

Fixes: zertosh#27
@chrisbobbe chrisbobbe linked a pull request Dec 14, 2021 that will close this issue
Open
@chrisbobbe
Copy link

And I've just sent #48 to fix the Flow type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

flow types: Make format argument required, like in implementation chrisbobbe/invariant
3 participants
@turadg @chrisbobbe @dsilvasc