Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The btree layout cant retain the width/height of the resized window. #139

Open
4 tasks done
lgjint opened this issue Apr 3, 2024 · 4 comments
Open
4 tasks done
Labels
bug Something isn't working

Comments

@lgjint
Copy link

lgjint commented Apr 3, 2024

Before you make the issue, confirm that

  • You are running the master build from GitHub actions
  • You have read the FAQ and the usage instructions
  • You have searched pull requests and issues and have found none similar to your issue
  • This problem comes from a failure in the tiling system and not a missing feature

Describe the bug

After adding a new window in a btree tile, it will revert to a fixed height-width split either by meta+t or by dagging on the edge of the window to resize it.

To reproduce

  1. Add two windows into a tile.
  2. Resize one window's width by meta+t or by dagging on the edge of the window.
  3. Add a new window into the tile.

Expected behavior

The btree layout should retain the width/height of the resized window.

Relevant log output

Apr 03 23:06:31 kwin_wayland[323153]: qml: Polonium DBG: Window footclient hooked into script
Apr 03 23:06:31 kwin_wayland[323153]: qml: Polonium DBG: Window footclient added
Apr 03 23:06:31 kwin_wayland[323153]: qml: Polonium DBG: Adding window footclient to desktops {"desktop":"f3939496-6b30-45a2-a583-9d4f33184659","activity":"dacd5c54-b72c-42d0-8ccc-f6d9f3cc75c9","output":"eDP-1"}
Apr 03 23:06:31 kwin_wayland[323153]: qml: Polonium DBG: Rebuilding layout for desktops {"desktop":"f3939496-6b30-45a2-a583-9d4f33184659","activity":"dacd5c54-b72c-42d0-8ccc-f6d9f3cc75c9","output":"eDP-1"}
Apr 03 23:06:31 systemd[1509]: Started Foot Client - Terminal.
Apr 03 23:06:32 kwin_wayland[323153]: qml: Polonium DBG: Window footclient hooked into script
Apr 03 23:06:32 kwin_wayland[323153]: qml: Polonium DBG: Window footclient added
Apr 03 23:06:32 kwin_wayland[323153]: qml: Polonium DBG: Adding window footclient to desktops {"desktop":"f3939496-6b30-45a2-a583-9d4f33184659","activity":"dacd5c54-b72c-42d0-8ccc-f6d9f3cc75c9","output":"eDP-1"}
Apr 03 23:06:32 kwin_wayland[323153]: qml: Polonium DBG: Rebuilding layout for desktops {"desktop":"f3939496-6b30-45a2-a583-9d4f33184659","activity":"dacd5c54-b72c-42d0-8ccc-f6d9f3cc75c9","output":"eDP-1"}
Apr 03 23:06:32 systemd[1509]: Started Foot Client - Terminal.
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:36 kwin_wayland[323153]: qml: Polonium DBG: Layout modified for tile QRectF(0, 0, 1440, 900)
Apr 03 23:06:42 kwin_wayland[323153]: qml: Polonium DBG: Window footclient hooked into script
Apr 03 23:06:42 kwin_wayland[323153]: qml: Polonium DBG: Window footclient added
Apr 03 23:06:42 kwin_wayland[323153]: qml: Polonium DBG: Adding window footclient to desktops {"desktop":"f3939496-6b30-45a2-a583-9d4f33184659","activity":"dacd5c54-b72c-42d0-8ccc-f6d9f3cc75c9","output":"eDP-1"}
Apr 03 23:06:42 kwin_wayland[323153]: qml: Polonium DBG: Rebuilding layout for desktops {"desktop":"f3939496-6b30-45a2-a583-9d4f33184659","activity":"dacd5c54-b72c-42d0-8ccc-f6d9f3cc75c9","output":"eDP-1"}
Apr 03 23:06:42 systemd[1509]: Started Foot Client - Terminal.

Screenshots and videos

2024-04-03.22-12-31.mp4

Additional context

No response

@lgjint lgjint added the bug Something isn't working label Apr 3, 2024
@zeroxoneafour zeroxoneafour added the needs log I assume you forgot? label Apr 3, 2024
@zeroxoneafour
Copy link
Owner

Needs log

@lgjint
Copy link
Author

lgjint commented Apr 3, 2024

Needs log

Sorry, added

@zeroxoneafour zeroxoneafour removed the needs log I assume you forgot? label Apr 3, 2024
@zeroxoneafour
Copy link
Owner

I could not reproduce this issue. Make sure you are running the latest commit build of the script. Try increasing the "Callback delay" slider in the script settings to around halfway if the latest commit doesn't fix this issue. Note that this will delay application of the new tile sizing for around 100ms, which may result in a marginally laggier experience.

@lgjint
Copy link
Author

lgjint commented Apr 4, 2024

I could not reproduce this issue. Make sure you are running the latest commit build of the script. Try increasing the "Callback delay" slider in the script settings to around halfway if the latest commit doesn't fix this issue. Note that this will delay application of the new tile sizing for around 100ms, which may result in a marginally laggier experience.

Solved, the bug only occurs when Callback delay is set to 0.

But it seems that this kind of retention the width/height will continue even after closing all the windows in a tile, is it better to restore the default split ratio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants