Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested common properties #155

Open
lejige opened this issue Jan 28, 2014 · 0 comments
Open

Suggested common properties #155

lejige opened this issue Jan 28, 2014 · 0 comments

Comments

@lejige
Copy link

lejige commented Jan 28, 2014

Using recently the lib , I added the following properties in the source code which I found useful:

In SendReceiveExtension:

public static SendStatus SendMessage(this ZmqSocket socket, ZmqMessage message, TimeSpan frameTimeout)

We have a ReceiveMessage with frameTimeout but not a SendMessage.

In ZmqMessage :

    public void Append(Frame[] frames)

with the corresponding overload of

internal void AppendShallowCopy(Frame[] frames)

Just call NormalizeFrames one time at the end.

And the last one, as _frames is private readonly, and I dont want to create hundreds of ZmqMessage and Wrap/Unwrap are not that cool:

    public void Clear()
    {
        _frames.Clear();
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant