Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Milesone is not unique in project #377

Open
g4s8 opened this issue Jul 26, 2018 · 3 comments
Open

Milesone is not unique in project #377

g4s8 opened this issue Jul 26, 2018 · 3 comments
Labels

Comments

@g4s8
Copy link
Contributor

g4s8 commented Jul 26, 2018

Now we just save mileston name as id:

<milestones updated="2018-07-26T17:42:53Z" version="0.62.2" xsi:noNamespaceSchemaLocation="http://datum.zerocracy.com/0.62.2/xsd/pm/time/milestones.xsd">
  <milestone id="gh:test">
    <date>2018-07-26T00:00:00Z</date>
  </milestone>
</milestones>

that is not correct, because Zerocracy project may contain few Github repositories with same milestone names. Let's add additional attribute repo and check the uniqueness by two attributes (same as in releases.xml):

<milestones updated="2018-07-26T17:42:53Z" version="0.62.2" xsi:noNamespaceSchemaLocation="http://datum.zerocracy.com/0.62.2/xsd/pm/time/milestones.xsd">
  <milestone repo="zerocracy/farm" id="gh:test">
    <date>2018-07-26T00:00:00Z</date>
  </milestone>
</milestones>
@g4s8
Copy link
Contributor Author

g4s8 commented Jul 26, 2018

@0crat in

@0crat 0crat added the scope label Jul 26, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 26, 2018

@0crat in (here)

@g4s8 Job #377 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jul 26, 2018

Bug was reported, see §29: +15 point(s) just awarded to @g4s8/z

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants