1.4.6.beta : issue with ipBlocker

[vincent3569]

hi

If I enable ipBlocker in admin>plugins, I have a blank page when I apply.
If ipBlocker is disabled, and I try to access to plugin options with the relevant button in admin>plugins, I have these warnings in admin>options>plugin:

btw: I don't change any option since last install.

[sbillard]

I cannot reproduce this, neither in English nor French.

But there must be another error somewhere. That is the only thing that causes these "cannot modify headers" warnings.

The error is happening because the plugin thinks it should be blocking the IP address. That should not be happening when the plugin is disabled, so I will fix that condition.

I would guess that the blank screen when you enable the plugin is caused by it blocking your IP address. To understand that we need to know what all the options are and what your IP address is.

[vincent3569]

I can't reproduce the issue at home (I guess taht I have an 'allowed' IP).
I will have another try tomorrow moring at job.

in my database, I found thses options:
with a filter %Blocker% on creator, and a filter %Blocker% on option name:

current options of the plugin are empy, but it seems there are older options with IP values. I hope they are not used by the plugin.
if these optiions are deprecated, it should be some cleanup during setup process (#768)

[sbillard]

failed_access_blocker_forbidden is obsolete. But as you can see from the record, there was not indication of where it was created, so no real means for deleting it without human intelligence. (See #768.) Same is probably true for ipBlocker but I do not know when that was ever an option.

The others are current options. Note, though, that not all are user options, For instance, the forbidden list is used internally to manage timeouts for excessive hack attempts. But if you IP is found in that list it will be blocked (presuming the plugin is enabled.) But the block should be removed when the timeout expires.

[sbillard]

Any uipdate?

[vincent3569]

since the last commit, I can't reproduce the issue.

[sbillard]

Ok, guess that the fix got all issues. Thanks.