You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
kud1ing opened this issue
May 3, 2024
· 2 comments
· Fixed by #11691
Labels
defect[core label]editorFeedback for code editing, formatting, editor iterations, etclanguageAn umbrella label for all programming languages syntax behaviorsrustRust programming language support
If you jump to the definition of a function or module etc. using Command click, the target is not only jumped to but also enclosed in a text selection. For functions this is not that bothering, but if you jump to a module the whole module code is selected.
I think just jumping to functions, modules etc. should be sufficient and the targets should not be selected. At least i do not see at the moment why someone would need the text selection - for copying, or deletion?
IntelliJ's (now discontinued) Rust plugin also handled this by just jumping to the target without selecting it.
kud1ing
changed the title
Rust: jump to definition (Command Click) should not add mark the target with a text selection
Rust: jump to definition (Command Click) should not mark the target with a text selection
May 3, 2024
kud1ing
changed the title
Rust: jump to definition (Command Click) should not mark the target with a text selection
Rust: jump to definition (Command Click) should not enclose the target within a text selection
May 3, 2024
kud1ing
changed the title
Rust: jump to definition (Command Click) should not enclose the target within a text selection
Rust: jump to definition (Command click) should not enclose the target within a text selection
May 3, 2024
kud1ing
changed the title
Rust: jump to definition (Command click) should not enclose the target within a text selection
Rust: jump to definition (Command click) should not enclose the target with a text selection
May 3, 2024
JosephTLyons
added
editor
Feedback for code editing, formatting, editor iterations, etc
rust
Rust programming language support
language
An umbrella label for all programming languages syntax behaviors
and removed
triage
Maintainer needs to classify the issue
admin read
Pending admin review
labels
May 3, 2024
The definition is not selected, but is actually kind of "highlighted" for a short while.
Also, when the definition is already in view, VSCode won't scroll, which is certainly visually clearer (compared to Zed's current behavior), but that would be another issue.
defect[core label]editorFeedback for code editing, formatting, editor iterations, etclanguageAn umbrella label for all programming languages syntax behaviorsrustRust programming language support
Check for existing issues
Describe the bug / provide steps to reproduce it
If you jump to the definition of a function or module etc. using Command click, the target is not only jumped to but also enclosed in a text selection. For functions this is not that bothering, but if you jump to a module the whole module code is selected.
I think just jumping to functions, modules etc. should be sufficient and the targets should not be selected. At least i do not see at the moment why someone would need the text selection - for copying, or deletion?
IntelliJ's (now discontinued) Rust plugin also handled this by just jumping to the target without selecting it.
Environment
Zed: v0.133.7 (Zed)
OS: macOS 14.4.1
Memory: 32 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
This shows the result of jumping to the
glob
module. The whole module is selected.If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.No response
The text was updated successfully, but these errors were encountered: