Avoid shadows and borders of nested cards being removed #2301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to avoid the confusion discussed in #726, #1295, #2265, where child elements of
ui.card
loose shadow and borders. This happens due to Quasar's CSS definitions, which are optimized for "tight" cards. NiceGUI adds some padding and gap by default, so shadow and borders seem to be missing for no obvious reason.Unfortunately we can't undo Quasar's CSS setting. But I found a way to make them ineffective by inserting another div layer, catching Quasar's CSS setting, while the actual card content isn't affected.
I tested with the following scenarios:
Only when working with "tight" cards, the result is suboptimal. But I guess it's more intuitive to remove unwanted borders in this case than to wonder why they magically disappear.