Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Serialization #339

Open
impoetk opened this issue Nov 27, 2023 · 8 comments
Open

Issue Serialization #339

impoetk opened this issue Nov 27, 2023 · 8 comments

Comments

@impoetk
Copy link

impoetk commented Nov 27, 2023

Trying to use WriteXml and ReadXml or WriteJson and ReadJson fails to set the identifiablename properties back from the generated xml/json

i think the issue is related to the read methods rely on the { id = , name = } and the write methods write them as { project_id = }

@zapadi
Copy link
Owner

zapadi commented Nov 27, 2023

Hi,
How do you intend to use the Write/Read xml/json methods?

@impoetk
Copy link
Author

impoetk commented Nov 27, 2023

Hello

Thanks for the quick reply, I intend to write a cache of issues in my application since the issue count is already over 5000 and paged results is quite slow, so my idea is to have a perpetual system reading updates (with local-lan access) from redmine, and then the other side of the application can interact with the services

for this i need to be able to reliably serialize and deserialize the issues locally in my assembly, i tried using the read/write json perhaps a new method that can be called "Serialize" and "Deserialize" will help a lot in this regard

@impoetk
Copy link
Author

impoetk commented Nov 28, 2023

I could do the changes my self, but i'm not sure if you like the approach of additional serialization methods or perhaps an optional flag passed to the write/read mehtods indicating if it should be to localscope or redmine api scope

@zapadi
Copy link
Owner

zapadi commented Nov 28, 2023

Please, open a PR with proposed changes

@impoetk
Copy link
Author

impoetk commented Nov 29, 2023

made the pr #340

@impoetk
Copy link
Author

impoetk commented Dec 19, 2023

hello, can you review and perhaps comment on the approach?

@zapadi
Copy link
Owner

zapadi commented Dec 19, 2023

I've reviewed the Pull Requests (PR) and I am considering an alternative approach involving converters (XML and JSON). This would ensure a complete separation of the serialization and deserialization processes from Redmine objects. The project has recently undergone significant internal modifications, and I'll be sharing these updates shortly.

@impoetk
Copy link
Author

impoetk commented Dec 20, 2023

If you need a helping hand with that just let me know I'll gladly help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants