Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple comparison correction #32

Open
jbao opened this issue Jun 27, 2016 · 2 comments
Open

multiple comparison correction #32

jbao opened this issue Jun 27, 2016 · 2 comments

Comments

@jbao
Copy link

jbao commented Jun 27, 2016

No description provided.

@LappleApple
Copy link

Hey @jbao @mkolarek @elezar, Still planning on this? Want to add a Help Wanted label?

@jbao
Copy link
Author

jbao commented Feb 7, 2017

@LappleApple Yes, this is still relevant, some ideas from @robertmuil

  • Decide on where to implement (I think in results is a good place)
  • Decide when it will be performed (it will depend on the use, I think)
  • Decide over which analyses it will be performed (I think within the 'type' is correct: all subgroups analysed in all SGAs, and, separately, all KPIs that have an uplift/delta calculation)
  • Implement simes-hochberg with potential to select over which comparisons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants