Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result Structure Improvement #189

Open
shansfolder opened this issue Feb 1, 2018 · 4 comments
Open

Result Structure Improvement #189

shansfolder opened this issue Feb 1, 2018 · 4 comments
Assignees
@gbordyugov @shansfolder @daryadedik
Labels
enhancement

Comments

@shansfolder
Copy link
Contributor

Because of multiple testing correction, confidence interval will be broader. Besides, we might need to consider adding p-value into the result.

This is a reminder for us to discuss the result structure of a delta analysis.
@gbordyugov
Copy link
Contributor

#162

@daryadedik
Copy link
Contributor

daryadedik commented Feb 6, 2018 •
edited

  1. What is the problem with broader confidence intervals?
  2. We found out that we don't need to report p-values for correction.

Is this issue about the overall results structure improvement?

@shansfolder shansfolder changed the title Result Structure Result Structure Improvement Feb 6, 2018
@shansfolder
Copy link
Contributor Author

Yes this is about result structure improvement.
The two points might not make sense. :) Just a reminder for points to discuss.

@shansfolder
Copy link
Contributor Author

One idea we've touched is to create the Result class with mandatory and optional fields that is used to hold results for different types of methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbordyugov gbordyugov

@shansfolder shansfolder

@daryadedik daryadedik

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gbordyugov @shansfolder @daryadedik