Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature request) Autocomplete dialog support via scripting API #4395

Open
benkaiser opened this issue Nov 5, 2023 · 2 comments · May be fixed by #4397
Open

(Feature request) Autocomplete dialog support via scripting API #4395

benkaiser opened this issue Nov 5, 2023 · 2 comments · May be fixed by #4397
Labels
Type: Enhancement

Comments

@benkaiser
Copy link

Describe feature

I am currently trying to write a kanban board script extension. This will support rendering a note as a Kanban board.
One of the features I would like to implement is making it easy for users to link a specific kanban board item to a note in their library. For this, it would be great to leverage the noteAutocompleteService. Something as simple as api.getNoteAutocomplete() that resolves with a FNote object for the front-end API would be great.

What are your thoughts on implementing this? Should I attempt a pull-request to add this functionality?

Additional Information

No response
@zadam
Copy link
Owner

zadam commented Nov 5, 2023

Hi, you could give it a try.

You can take a look at e.g. api.prompt() which also triggers a dialog and can be awaited. I guess you could basically combine the prompt dialog with e.g. "jump to note" dialog for this.

@benkaiser benkaiser linked a pull request Nov 6, 2023 that will close this issue
Open
@benkaiser
Copy link
Author

Created a PR @zadam using your pointers and the implementation works! I've added a couple of comments where I might need your input. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add frontend note prompt API benkaiser/trilium
2 participants
@benkaiser @zadam