Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images messed up in live version (gluon.mxnet.io), but look good in Github version #552

Open
vitali-fedulov opened this issue Nov 30, 2018 · 7 comments

Comments

@vitali-fedulov
Copy link
Contributor

Images are in wrong order/position on page:
https://gluon.mxnet.io/chapter01_crashcourse/introduction.html

But all good on corresponding Github:
https://github.com/zackchase/mxnet-the-straight-dope/blob/master/chapter01_crashcourse/introduction.ipynb

@vishaalkapoor
Copy link
Collaborator

@vitali-fedulov can you include a screenshot with specification to the specific images out of place? It looks fine on my browser.

What browser are you using? Desktop/mobile? Can you try a different one to be sure?

@vitali-fedulov
Copy link
Contributor Author

I have tried it in most recent Chrome, Firefox in Ubuntu, and Firefox in Android. All show the same incorrect images:

Live:

live

Live HTML:

screenshot from 2018-11-30 17-22-52

GitHub version (as it should be):

git

@vishaalkapoor
Copy link
Collaborator

nice catch.

It looks like it's this issue with Sphinx:
spatialaudio/nbsphinx#162

it only happens when the "alt" tag for an image is an empty string. i see a few empty alt tags, so it could be useful to try to fill those in with some relevant text. if you want to give it a go and try adding alt image text feel free to submit a PR and i can take a look.

if not, I'll leave this issue open and someone, myself included might be able to get to it

vitali-fedulov added a commit to vitali-fedulov/mxnet-the-straight-dope that referenced this issue Nov 30, 2018
Fixing messed up pictures in Live version:
zackchase#552

Let's try to push this change to live. If it is indeed the reason,
I can check all other images in other chapters.
@vishaalkapoor
Copy link
Collaborator

@vitali-fedulov Looks like the merge fixed the issue, Thank you! I'll let you double check and close off this issue.

@vitali-fedulov
Copy link
Contributor Author

vitali-fedulov commented Dec 1, 2018 via email

@vishaalkapoor
Copy link
Collaborator

vishaalkapoor commented Dec 3, 2018

I think this will need to be fixed within Sphinx (possibly version upgrade). Leaving this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants