Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undoall does not undo changes in the local list #681

Open
FichteFoll opened this issue Mar 27, 2023 · 3 comments
Open

undoall does not undo changes in the local list #681

FichteFoll opened this issue Mar 27, 2023 · 3 comments

Comments

@FichteFoll
Copy link
Collaborator

FichteFoll [anilist] (anime) watching >> update 6
Engine: Updating show BLUELOCK to episode 24...
[D] Data: Saving queue...
[D] Data: Saving cache...
Data: Queued update for BLUELOCK
[D] Data: Queued: my_progress -> 24
Engine: Updating show BLUELOCK status to Completed...
[D] Data: Saving queue...
[D] Data: Saving cache...
Data: Queued update for BLUELOCK
[D] Data: Queued: my_status -> COMPLETED
[D] Data: Saving queue...
[D] Data: Saving cache...
Data: Queued update for BLUELOCK
[D] Data: Queued: my_finish_date -> 2023-03-27
FichteFoll [anilist] (anime) watching >> undoall
[D] Data: Saving queue...
Data: Cleared queue.
FichteFoll [anilist] (anime) watching >> update 6
Engine: Updating show BOFURI: I Don't Want to Get Hurt, so I'll Max Out My Defense. Season 2 to episode 8...
[D] Data: Queued: my_progress -> 8
FichteFoll [anilist] (anime) watching >> search blue
| Index  Title                                                                                                                          Progress  Score  |
0 results
@FichteFoll
Copy link
Collaborator Author

FichteFoll commented Apr 16, 2023

This actually extends to all operations performed to the local list, including adding or removing a show and updating a show's score or progress. While the update from the queue is cancelled, the update to the local list is not undone, causing the local and the remote list to be out of sync until it is retrieved.

@FichteFoll FichteFoll changed the title undoall does not undo status changes undoall does not undo changes in the local list Apr 16, 2023
@z411
Copy link
Owner

z411 commented Aug 19, 2023

This is probably bad naming from my part. undoall is supposed to clear the queue, not undo all changes in the local list because Trackma does not keep a history of changes. What actually undoes all changes in your local list is retrieve, which re-downloads the list ovewriting any changes. Maybe a change in command names is needed.

@FichteFoll
Copy link
Collaborator Author

Seeing how there is a viewqueue command, undoall should probably be renamed to clearqueue then. (retrieve is fine as-is.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants