Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync/async distinguishing in Selector #67

Open
yuriyyakym opened this issue Jan 4, 2024 · 0 comments
Open

Fix sync/async distinguishing in Selector #67

yuriyyakym opened this issue Jan 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@yuriyyakym
Copy link
Owner

Right now asyncSelector is used if either any of dependencies is async readable, or if predicate's constructor is AsyncFunction.

const isAsyncPredicate = predicate.constructor.name === 'AsyncFunction';

Source

Current behavior

It does not work in some JS engines, like JSC.

Expected behavior

It works in any JS engine.

@yuriyyakym yuriyyakym added the bug Something isn't working label Jan 4, 2024
@yuriyyakym yuriyyakym added this to the v1.0.0 Release milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant