{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":105944401,"defaultBranch":"master","name":"yugabyte-db","ownerLogin":"yugabyte","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-10-05T21:56:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/17074854?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714259763.0","currentOid":""},"activityList":{"items":[{"before":"379679de4170dae4be029f4cf933babb5e24b3ae","after":"6dc9ae7219a8632878488ab64a068cd4488be493","ref":"refs/heads/2.20","pushedAt":"2024-04-29T05:50:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"haikarthikssk","name":"Karthik K","path":"/haikarthikssk","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6438247?s=80&v=4"},"commit":{"message":"[BACKPORT 2.20][PLAT-13510][Platform]Change password reset url to new URL\n\nSummary: Backport of this [[ https://phorge.dev.yugabyte.com/D34112 | diff ]]\n\nTest Plan: Tested manually\n\nReviewers: lsangappa\n\nReviewed By: lsangappa\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34583","shortMessageHtmlLink":"[BACKPORT 2.20][PLAT-13510][Platform]Change password reset url to new…"}},{"before":"3e5cb1e49c6668f9028ce92db13afedf084a8097","after":"b35c5880675fb3bd9672feb10c44d515eca489f9","ref":"refs/heads/2024.1","pushedAt":"2024-04-29T05:27:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dr0pdb","name":"Saurav Tiwary","path":"/dr0pdb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/21277837?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#21950][#22133][#22143] YSQL: Backport Walsender debug logs and unacked txn fix\n\nSummary:\n##### Backport Description\nAll merges were clean. No conflicts.\n\n##### Original Description\nOriginal commits:\n1b902bab87e0f03a3600e156ae9c0e1153a3f8be / D34327\n48a027931faf9990c3c1aeaf11da801aaeeb77e2 / D34483\n5e24efffe63914fec0a42a63ab8bfbeb4b7aea8f / D34530\n\n###### YSQL: Insert transaction into unacked txn list only upon receipt of commit record\nWe maintain a list of unacked transactions for the calculation of the restart_lsn from the confirmed_flush lsn. Prior to this revision, this list also included a transaction at\nthe end for which we haven't yet received the COMMIT record from the CDC service. Such a transaction is stored with commit_lsn as InvalidXLogRecPtr (0) and was leading to issues in the calculation in the restart_lsn.\n\nThis revision updates the logic to put a transaction into the list only on the receipt of the commit record.\nJira: DB-10866\n\n###### YSQL: Log the time taken in converting from QLValuePB to PG datum in walsender\nThe walsender spends a considerable amount of time in converting QLValuePB to PG datum in ybc_pggate. Add a VLOG(1) which logs the time taken in this\noperation.\nJira: DB-11059\n\n###### YSQL: Log the time taken in yb_decode and reorder buffer\nThis revision adds computation and logging of the time taken by the Walsender in yb_decode and reorderbuffer while processing a single batch from the CDC\nservice.\nJira: DB-11071\n\nTest Plan: Jenkins: test regex: .*ReplicationSlot.*\n\nReviewers: asrinivasan, skumar\n\nReviewed By: skumar\n\nSubscribers: yql, ycdcxcluster\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34535","shortMessageHtmlLink":"[BACKPORT 2024.1][#21950][#22133][#22143] YSQL: Backport Walsender de…"}},{"before":"51f35fce4d3da3735d217c4524001640c1d7a727","after":"1087ffef9925830bf32ede0a263619be474ed2ca","ref":"refs/heads/master","pushedAt":"2024-04-29T03:57:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rahulb-yb","name":"Rahul Barigidad","path":"/rahulb-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/72571621?s=80&v=4"},"commit":{"message":"[#21750] YSQL: Stabilize TestPgRegressReplicationSlot tests with YSQL Connection Manager enabled\n\nSummary:\nThe test org.yb.pgsql.TestPgRegressReplicationSlot.testPgRegressReplicationSlot fails with Connection Manager enabled as the preview flags needed to enable Connection Manager get overridden during the test execution. This patch ensures that the required flags are safely added when the test is being run with Connection Manager enabled\n\nJira: DB-10624\n\nTest Plan: Jenkins: enable connection manager, test regex: .*TestPgRegressReplicationSlot.*\n\nReviewers: nkumar, mkumar\n\nReviewed By: nkumar\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34509","shortMessageHtmlLink":"[#21750] YSQL: Stabilize TestPgRegressReplicationSlot tests with YSQL…"}},{"before":"d2f6d93d4eae3cb8f05f9b5b1a38e516f88f6437","after":"fee5dbf3e057674e09c96020a8faa17e0ffc60ec","ref":"refs/heads/2.14","pushedAt":"2024-04-29T03:43:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Huqicheng","name":"Qicheng (Jonathan) Hú ","path":"/Huqicheng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31775227?s=80&v=4"},"commit":{"message":"[BACKPORT 2.14][#21371] docdb: Hidden split parent tablets showing as leaderless in master's leaderless tablet endpoint\n\nSummary:\nOriginal commit: 5f383333fa3d268293d25a024253cfa2bd2dfc45 / D33401\nCustomer Impact: Universe is showing the load balanced status as true, but upon checking replica info, it's discovered that there are leaderless tablets, which are actually hidden split parent tablets. If you have Point-In-Time Recovery (PITR) enabled, the tablets aren't actually deleted if you drop the table until the retention window ends; they are just put into a hidden state.\n\nThis issue can also occur in non-PITR scenarios where the split parent tablets are left undeleted for a long time (>120s). This can happen if one of the split children failed to register.\n\nCause: When the tablet is marked as TABLET_DATA_SPLIT_COMPLETED, metrics for this tablet are skipped from being sent to the master. Consequently, the leader lease is not updated on the master.\n\nThe fix is to also report metrics for tablets with state TABLET_DATA_SPLIT_COMPLETED.\nJira: DB-10268\n\nTest Plan: MasterPathHandlersItest.TestHiddenSplitParentTablet\n\nReviewers: asrivastava, zdrudi\n\nReviewed By: asrivastava\n\nSubscribers: bogdan, qhu, ybase\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D33716","shortMessageHtmlLink":"[BACKPORT 2.14][#21371] docdb: Hidden split parent tablets showing as…"}},{"before":"c4056b7ad8065d2f057d555be01c1916c8d7bf3f","after":"51f35fce4d3da3735d217c4524001640c1d7a727","ref":"refs/heads/master","pushedAt":"2024-04-29T03:23:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rahulb-yb","name":"Rahul Barigidad","path":"/rahulb-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/72571621?s=80&v=4"},"commit":{"message":"[#21757] YSQL: Support for single-use GUC variables in YSQL Connection Manager\n\nSummary:\nYSQL Connection Manager stores the context of altered GUC variables for each logical connection, and replays the stored context at the beginning of every transaction boundary on the physical connection being used. There are some variables that are implicitly set to a different value after a certain event has occurred.\nOne such example of this is `yb_test_fail_next_ddl`, which returns an error upon the execution of the next DDL statement, and then sets itself to false. These implicit changes cannot be tracked by Connection Manager, and this patch creates the provision for Connection Manager to do so.\n\nChanges in this diff:\n- Remove changes made as a \"hack\" to pass a test in TestYsqlUpgrade.java\n- When connection manager is the client, if any of the variables in the single-use category are implicitly changed, send a ParameterStatus packet back to Connection Manager\n\nJira: DB-10631\n\nTest Plan:\nJenkins: enable connection manager, test regex: .*TestYsqlUpgrade.*\n\n./yb_build.sh --enable-ysql-conn-mgr-test --java-test org.yb.pgsql.TestYsqlUpgrade#creatingSystemRelsAfterFailure\n\nReviewers: nkumar, mkumar\n\nReviewed By: nkumar\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34450","shortMessageHtmlLink":"[#21757] YSQL: Support for single-use GUC variables in YSQL Connectio…"}},{"before":"a5a05d0a12335d002753d234a26343347c52053e","after":"c4056b7ad8065d2f057d555be01c1916c8d7bf3f","ref":"refs/heads/master","pushedAt":"2024-04-28T10:54:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Vars-07","name":"Shubham Varshney","path":"/Vars-07","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19248012?s=80&v=4"},"commit":{"message":"[PLAT-13681] Generate YBA Managed bundles in case the provider contains legacy bundles\n\nSummary:\nBefore the VM_OS_Patching flag is enabled we do not set the versions in the `yugaware_property` because of which the\nbundles were not getting generated even in case YBA moved to a higher version.\n\nWith this diff, we fix the same & generates the bundle.\n1. If the version specified in the `yugaware_property` does not match the one present in `CloudImageBundleSetup`.\n2. Bundles are legacy one without the metadata.\n\nTest Plan:\nCreated a provider in YBA 2.18\nMigrated the same to the YBA version having the patch applied.\nVerified that the bundles are getting generated as expected.\n\nChanged the version in YBA metadata manually\nVerified that the bundles are generated as expected.\n\nReviewers: amalyshev\n\nReviewed By: amalyshev\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34469","shortMessageHtmlLink":"[PLAT-13681] Generate YBA Managed bundles in case the provider contai…"}},{"before":"e5fe1c6844bb342c3ec9c61e3d9e7b76c890cf1b","after":"3e5cb1e49c6668f9028ce92db13afedf084a8097","ref":"refs/heads/2024.1","pushedAt":"2024-04-27T17:07:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdbridge","name":"Mark","path":"/mdbridge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15827795?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#22161] DocDB: Gate new memory default recommendations on an ordinary gflag\n\nSummary:\nOriginal commit: b64cac3dfb4e31c2057eb24076454daf4bb5715b / D34547\nClean cherry pick, no conflicts.\n\nHere we introduce a new gflag:\n```\n~/code/yugabyte-db/src/yb/tserver/server_main_util.cc:36:\nDEFINE_NON_RUNTIME_bool(\n use_memory_defaults_optimized_for_ysql, false,\n \"If true, the recommended defaults for the memory usage settings take into account the amount \"\n \"of RAM and cores available and are optimized for using YSQL. \"\n \"If false, the recommended defaults will be the old defaults, which are more suitable \"\n \"for YCQL but do not take in account the amount of RAM and cores available.\");\n```\nto gate the new memory recommendations.\n\nMore precisely, we still have a concept of recommended defaults and individual memory settings can choose whether or not to use the recommended defaults. For example:\n```\n~/code/yugabyte-db/src/yb/tserver/tablet_memory_manager.cc:59:\n// NOTE: The default here is for tools and tests; the actual defaults\n// for the TServer and master processes are set in server_main_util.cc.\nDEFINE_NON_RUNTIME_int32(tablet_overhead_size_percentage, 0,\n \"Percentage of total available memory to use for tablet-related overheads. A value of 0 means \"\n \"no limit. Must be between 0 and 100 inclusive. Exception: \"\n BOOST_PP_STRINGIZE(USE_RECOMMENDED_MEMORY_VALUE) \" specifies to instead use a \"\n \"recommended value determined in part by the amount of RAM available.\");\n```\nIf this gflag is set to USE_RECOMMENDED_MEMORY_VALUE by the customer or left unset (the gflag default is set to that value for the TServer and master processes elsewhere), then we will use the recommended default for it.\n\nIf the new gflag is set to true then we use the new recommendations we have derived using our models. If it is set to false, then we use the same values we would've used prior to version 2024.1 if the customer had not provided a value for this gflag.\n\nThus, the customer gets essentially the same behavior as before 2024.1 if they do not set the new gflag.\nJira: DB-11090\n\nTest Plan:\nStarted cluster with and without flag on and look at logs:\n```\n~/code/yugabyte-db/bin/yb-ctl start\n\nI0425 10:52:25.180203 5935 server_main_util.cc:90] Setting flag db_block_cache_size_percentage to recommended value -3\nI0425 10:52:25.180212 5935 server_main_util.cc:92] Flag default_memory_limit_to_ram_ratio has value 0.65 (recommended value is 0.85)\nI0425 10:52:25.180217 5935 server_main_util.cc:94] Setting flag tablet_overhead_size_percentage to recommended value 0\n```\n\n```\nbin/yb-ctl start --tserver_flags \"use_memory_defaults_optimized_for_ysql=true\" \\\n --master_flag \"use_memory_defaults_optimized_for_ysql=true\"\n\nI0425 10:57:00.198920 6412 server_main_util.cc:101] Total available RAM is 31.183224 GiB\nI0425 10:57:00.198928 6412 server_main_util.cc:90] Setting flag db_block_cache_size_percentage to recommended value 32\nI0425 10:57:00.198938 6412 server_main_util.cc:92] Flag default_memory_limit_to_ram_ratio has value 0.65 (recommended value is 0.6)\nI0425 10:57:00.198943 6412 server_main_util.cc:94] Setting flag tablet_overhead_size_percentage to recommended value 10\n```\n(yb-ctl overrides default_memory_limit_to_ram_ratio.)\n\nReviewers: zdrudi, slingam\n\nReviewed By: slingam\n\nSubscribers: ybase\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34565","shortMessageHtmlLink":"[BACKPORT 2024.1][#22161] DocDB: Gate new memory default recommendati…"}},{"before":"a91117f503f9a7c74912ecbd0161410d579feb16","after":"a5a05d0a12335d002753d234a26343347c52053e","ref":"refs/heads/master","pushedAt":"2024-04-27T14:13:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"druzac","name":null,"path":"/druzac","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/865068?s=80&v=4"},"commit":{"message":"[#22118] docdb: add tablet replica limit information to master ui tablet servers page\n\nSummary:\nAdd an overview table to the tablet server status page. This table is broken down by placement cluster and lists tablet peer counts. It has a new column for hidden tablet peers which is not displayed anywhere else in the UI.\n\nBlacklisted and hidden peer:\n{F173985}\n\nDead peer:\n{F173986}\nJira: DB-11045\n\nTest Plan:\nmanual inspection of some scripted scenarios, unfortunately.\n\n```\n#!/bin/zsh\n\nsource ~/.config/zsh/yb.zsh\nlive_nodes=3\nread_nodes=2\nprefix=$HOME/yugabyted_clusters\n\nyugabyted start --advertise_address=127.0.0.1 --base_dir=${prefix}/live_cluster/node-1\n\nfor i in $(seq 2 $live_nodes)\ndo\n echo ${prefix}/node-$i\n yugabyted start --join 127.0.0.1 --advertise_address=127.0.0.$i --base_dir=${prefix}/live_cluster/node-$i\ndone\n\nfor i in $(seq $read_nodes)\ndo\n advertise_addr_suffix=$(($live_nodes + $i))\n echo $advertise_addr_suffix\n advertise_address=127.0.0.$advertise_addr_suffix\n echo $advertise_address\n yugabyted start --join 127.0.0.1 --advertise_address=127.0.0.$advertise_addr_suffix --base_dir=${prefix}/read_cluster/node-$i --read_replica\ndone\n\nyugabyted configure_read_replica new --rf=$read_nodes --base_dir=~/yugabyted_clusters/read_cluster/node-1\n\nybactl create_snapshot_schedule 1 5 ysql.yugabyte\n\nsleep 3\n\nysqlsh <#22118] docdb: add tablet replica limit information to master ui tab…"}},{"before":"47411c383c43b0794021d69da138f822a48f839c","after":"e5fe1c6844bb342c3ec9c61e3d9e7b76c890cf1b","ref":"refs/heads/2024.1","pushedAt":"2024-04-27T04:47:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hari90","name":"Hari Krishna Sunder","path":"/hari90","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12418230?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#21538,#21539,#20694] xCluster: Add DbScoped APIs and yb-admin commands\n\nSummary:\nOriginal commit: a91117f503f9a7c74912ecbd0161410d579feb16 / D34088\n- Added `ValidateTableListForDbScopedReplication` which will make sure all tables are included when a database is added to xCluster DB Scoped replication. This protects us from missing tables that can potentially be added between checkpointing and backing up the source database. #20694\n- `namespace_name_to_add` and `producer_namespace_id_to_add` have been added to `AlterUniverseReplicationRequestPB`. For DB Scoped replication we only allow adding individual tables to existing replication to handle creation of new tables. When a entire database is added we will perform `ValidateTableListForDbScopedReplication`. On the merge of the Alter Replica Group we merge the namespaces into the original Replication Group.\n- `producer_namespace_id_to_remove` has been added to `AlterUniverseReplicationRequestPB`. This will remove an entire database from the Replication Group on the target. `RemoveNamespaceFromReplicationGroup` removes the namespace from the `db_scoped_info` and then performs the regular remove table over all tables in the database.\n- Add optional `universe_uuid` to `DeleteUniverseReplicationRequestPB` and `AlterUniverseReplicationRequestPB`. When set the target will make sure the value matches its universe_uuid. This protects us from user errors when incorrect master addresses are used.\n- Replaced `string` type namespace name identifiers with `NamespaceIdentifierPB` in `XClusterCreateOutboundReplicationGroupRequestPB` and `XClusterAddNamespaceToOutboundReplicationGroupRequestPB`. YBA can now use ID based identification, and yb-admin can use the name.\n- `XClusterRemoveNamespaceFromOutboundReplicationGroupRequestPB` and `XClusterDeleteOutboundReplicationGroupRequestPB` now take an optional `target_master_addresses`. When this is set we will delete the database/replication group on the target first and then proceed with the cleanup on the source.\n- yb-admin commands `add_namespace_to_xcluster_checkpoint`, `add_namespace_to_xcluster_replication`, and `remove_namespace_from_xcluster_replication` have been added. `drop_xcluster_replication` now takes in optional `target_master_addresses`. `alter_universe_replication` has a new command `remove_namespace `\n\n**Upgrade/Rollback safety:**\nNew/modified proto messages and rpcs are guarded under flag `TEST_enable_xcluster_api_v2`.\nAdditions to existing proto fields are all optional.\n\nFixes #21538\nFixes #21539\nFixes #20694\nJira: DB-10423, DB-10424, DB-9698\n\nTest Plan:\nXClusterTest.DeleteWhenSourceIsDown\nClusterDBScopedTest.AddRemoveNamespace\nXClusterDBScopedTest.RemoveNamespaceWhenTargetIsDown\nXClusterDBScopedTest.RemoveNamespaceWhenSourceIsDown\nXClusterDBScopedTest.Delete\nXClusterDBScopedTest.DeleteWhenTargetIsDown\nXClusterDBScopedTest.DeleteWhenSourceIsDown\nXClusterDBScopedTest.TestYbAdmin\n\nReviewers: jhe, xCluster\n\nReviewed By: jhe\n\nSubscribers: xCluster, ybase, cwang\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34574","shortMessageHtmlLink":"[BACKPORT 2024.1][#21538,#21539,#20694] xCluster: Add DbScoped APIs a…"}},{"before":"e404d68a9caf7a70874940a8e2626dbd9893df3e","after":"a91117f503f9a7c74912ecbd0161410d579feb16","ref":"refs/heads/master","pushedAt":"2024-04-26T20:51:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hari90","name":"Hari Krishna Sunder","path":"/hari90","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12418230?s=80&v=4"},"commit":{"message":"[#21538,#21539,#20694] xCluster: Add DbScoped APIs and yb-admin commands\n\nSummary:\n- Added `ValidateTableListForDbScopedReplication` which will make sure all tables are included when a database is added to xCluster DB Scoped replication. This protects us from missing tables that can potentially be added between checkpointing and backing up the source database. #20694\n- `namespace_name_to_add` and `producer_namespace_id_to_add` have been added to `AlterUniverseReplicationRequestPB`. For DB Scoped replication we only allow adding individual tables to existing replication to handle creation of new tables. When a entire database is added we will perform `ValidateTableListForDbScopedReplication`. On the merge of the Alter Replica Group we merge the namespaces into the original Replication Group.\n- `producer_namespace_id_to_remove` has been added to `AlterUniverseReplicationRequestPB`. This will remove an entire database from the Replication Group on the target. `RemoveNamespaceFromReplicationGroup` removes the namespace from the `db_scoped_info` and then performs the regular remove table over all tables in the database.\n- Add optional `universe_uuid` to `DeleteUniverseReplicationRequestPB` and `AlterUniverseReplicationRequestPB`. When set the target will make sure the value matches its universe_uuid. This protects us from user errors when incorrect master addresses are used.\n- Replaced `string` type namespace name identifiers with `NamespaceIdentifierPB` in `XClusterCreateOutboundReplicationGroupRequestPB` and `XClusterAddNamespaceToOutboundReplicationGroupRequestPB`. YBA can now use ID based identification, and yb-admin can use the name.\n- `XClusterRemoveNamespaceFromOutboundReplicationGroupRequestPB` and `XClusterDeleteOutboundReplicationGroupRequestPB` now take an optional `target_master_addresses`. When this is set we will delete the database/replication group on the target first and then proceed with the cleanup on the source.\n- yb-admin commands `add_namespace_to_xcluster_checkpoint`, `add_namespace_to_xcluster_replication`, and `remove_namespace_from_xcluster_replication` have been added. `drop_xcluster_replication` now takes in optional `target_master_addresses`. `alter_universe_replication` has a new command `remove_namespace `\n\n**Upgrade/Rollback safety:**\nNew/modified proto messages and rpcs are guarded under flag `TEST_enable_xcluster_api_v2`.\nAdditions to existing proto fields are all optional.\n\nFixes #21538\nFixes #21539\nFixes #20694\nJira: DB-10423, DB-10424, DB-9698\n\nTest Plan:\nXClusterTest.DeleteWhenSourceIsDown\nClusterDBScopedTest.AddRemoveNamespace\nXClusterDBScopedTest.RemoveNamespaceWhenTargetIsDown\nXClusterDBScopedTest.RemoveNamespaceWhenSourceIsDown\nXClusterDBScopedTest.Delete\nXClusterDBScopedTest.DeleteWhenTargetIsDown\nXClusterDBScopedTest.DeleteWhenSourceIsDown\nXClusterDBScopedTest.TestYbAdmin\n\nReviewers: jhe, xCluster\n\nReviewed By: jhe\n\nSubscribers: cwang, ybase, xCluster\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34088","shortMessageHtmlLink":"[#21538,#21539,#20694] xCluster: Add DbScoped APIs and yb-admin commands"}},{"before":"b7d0c375c5eeea03d30aede3f1a2080b18adf621","after":"47411c383c43b0794021d69da138f822a48f839c","ref":"refs/heads/2024.1","pushedAt":"2024-04-26T19:17:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rajmaddy89","name":"Rajagopalan Madhavan","path":"/rajmaddy89","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10095310?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-13666]: Add a API call to refresh releases, fix error message on add release\n\nSummary:\n1. Add a PUT API call to refresh releases\n2. Disable Delete/Disable Deployment button for releases in use\n3. Proper Error Message Not Displayed When Adding Duplicate Release\n4. On create release page, ensure to show the versions that are ACTIVE\n\nTest Plan:\nPlease refer to screenshots\n{F173401}\n\n{F173402}\n\nOriginal diff: 4bff1d7/D34495\n\nReviewers: jmak, dshubin\n\nReviewed By: jmak, dshubin\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34555","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-13666]: Add a API call to refresh releases, fi…"}},{"before":"c295c1069eedd9cc473b10dd8e606f38ecc49e16","after":"e404d68a9caf7a70874940a8e2626dbd9893df3e","ref":"refs/heads/master","pushedAt":"2024-04-26T15:54:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Huqicheng","name":"Qicheng (Jonathan) Hú ","path":"/Huqicheng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/31775227?s=80&v=4"},"commit":{"message":"[#21699] docdb: clear colocation_to_table before loading from metadata protobuf\n\nSummary:\nAt remote bootstrap, tablet metadata was replaced with the downloaded super block. When loading the new super block to memory,\ncolocation_to_table is not cleared. Also we set the colocation_to_table map with `emplace` method but it cannot overwrite the\nold data:\n```\nif (schema.has_colocation_id()) {\n colocation_to_table.emplace(schema.colocation_id(), table_info);\n}\n```\n\nIf colocation_to_table has stale data, it can lead to corruption of SST files after a compaction because the old schema version could be used as the latest schema version and pack the unpacked rows with it, see `GetCompactionSchemaInfo` which gets the new_packing data.\n\nJira: DB-10579\n\nTest Plan: PgPackedRowTest.*\n\nReviewers: sergei\n\nReviewed By: sergei\n\nSubscribers: ybase\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34556","shortMessageHtmlLink":"[#21699] docdb: clear colocation_to_table before loading from metadat…"}},{"before":"c27f6ed4d8b0c0948600d4208a510167676bb4ab","after":"b7d0c375c5eeea03d30aede3f1a2080b18adf621","ref":"refs/heads/2024.1","pushedAt":"2024-04-26T15:15:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hari90","name":"Hari Krishna Sunder","path":"/hari90","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12418230?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#21540] xCluster: Add Repair APIs for DB Scoped replication\n\nSummary:\nOriginal commit: 0ac8a65932ce0bbd5f510d592b143d4ce8e33785 / D34239\nPartial commit: 7b2565184dfabe57f6196e8cfda80a064acf3980 / D33878 src/yb/client/client-internal.cc\n\nAdding yb-admin commands:\n`repair_xcluster_outbound_replication_add_table `\n`repair_xcluster_outbound_replication_remove_table `\n\nThese will alow us to manually add or remove an individual table from the source side Outbound Replication Group.\n`repair_xcluster_outbound_replication_add_table` requires a stream_id which can be created using `bootstrap_cdc_producer`.\n`repair_xcluster_outbound_replication_remove_table` will not delete the xcluster stream. It will have to be manually deleted with `delete_cdc_stream`.\nNOTE: This is only meant for manual use by DevOps in extreme situations.\n\n**Upgrade/Rollback safety:**\nNew proto messages and APIs are guarded under `enable_xcluster_api_v2`\n\nFixes #21540\nJira: DB-10425\n\nTest Plan:\nXClusterOutboundReplicationGroupTest.Repair\nXClusterOutboundReplicationGroupTest.RepairWithYbAdmin\nXClusterDBScopedTest.DropTableOnProducerThenConsumer\nXClusterDBScopedTest.DropAllTables\nXClusterDBScopedTest.DisableAutoTableProcessing\n\nReviewers: jhe, slingam, xCluster\n\nReviewed By: slingam\n\nSubscribers: ybase, xCluster\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34558","shortMessageHtmlLink":"[BACKPORT 2024.1][#21540] xCluster: Add Repair APIs for DB Scoped rep…"}},{"before":"f68dcdc39bfd9aacce607f601b06f96046f7d7d0","after":"379679de4170dae4be029f4cf933babb5e24b3ae","ref":"refs/heads/2.20","pushedAt":"2024-04-26T13:08:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"yorq","name":"Yuriy Shchetinin","path":"/yorq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/90446433?s=80&v=4"},"commit":{"message":"[BACKPORT-2.20][PLAT-12959] No error is shown when added zone doesn't have any available nodes\n\nSummary:\nOriginal diff: d87d665ba47d270b11e70a001c3e5a7cda46b3b8/D33380\n\nIf user sends universe configure request with `userAZSelected` we trust that placement\nbut validate that it is correct (in case of onprem)\nWe take into account nodes from all cluster, but prior to that diff we verified only placement from current cluster.\nTo verify that there are enough nodes we should check both placements.\n\nTest Plan:\nsbt test\n\n1) Create onprem universe with different regions for clusters.\n2) Switch az in primary with az from RR (if there are not enough nodes)\n3) Observe error\n\nReviewers: rmadhavan\n\nReviewed By: rmadhavan\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D33940","shortMessageHtmlLink":"[BACKPORT-2.20][PLAT-12959] No error is shown when added zone doesn't…"}},{"before":"0234fbfdb52027099e8c19f1f0662a34e1f78a34","after":"c27f6ed4d8b0c0948600d4208a510167676bb4ab","ref":"refs/heads/2024.1","pushedAt":"2024-04-26T12:31:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"yorq","name":"Yuriy Shchetinin","path":"/yorq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/90446433?s=80&v=4"},"commit":{"message":"[BACKPORT-2024.1][PLAT-13703] Do not run AreNodesSafeToTakeDown for retry tasks\n\nSummary:\nOriginal diff: 9cfd92c8ad7168f5d986a6877ecf1b8bc5093484/D34542\n\nIf we retry a task, one of nodes could be stopped at the moment.\nAnd for this case, in RF3 3-node universe, this will fail (because it will test all the nodes one by one)\nBut eventual upgrade will be successful (because we will process failed server first)\n\nTest Plan: sbt test\n\nReviewers: cwang, sanketh, nsingh\n\nReviewed By: cwang\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34546","shortMessageHtmlLink":"[BACKPORT-2024.1][PLAT-13703] Do not run AreNodesSafeToTakeDown for r…"}},{"before":"7cb173c42ad39f00b1c0d6c6f621cc8542b613dd","after":"c295c1069eedd9cc473b10dd8e606f38ecc49e16","ref":"refs/heads/master","pushedAt":"2024-04-26T06:13:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SrivastavaAnubhav","name":"Anubhav Srivastava","path":"/SrivastavaAnubhav","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/17299377?s=80&v=4"},"commit":{"message":"[#21572] docdb: Clone hidden tables from active rocksdb\n\nSummary:\nWhen cloning to time `t`, some of the tablets which were running as of `t` might have been deleted before the snapshot covering time `t` was taken.\nSince we do not snapshot hidden tables, the SST files for these tablets must be hardlinked from the tablet's active rocksdb (since the tablets are hidden, there is no difference between the data in the active rocks db and the data as of `t`). Note that it is not sufficient to clone from active rocksdb for all tablets that are hidden when the clone operation starts because if a tablet **was** included in the covering snapshot, then active rocksdb is only guaranteed to contain information after the covering snapshot time.\n\nThis diff adds the above functionality by keeping track of which tablets were not part of the covering snapshot, and setting the new field `clone_from_active_rocksdb` in the clone requests for those tablets.\n\n**Upgrade/Rollback safety:**\nChange is to an API (CloneTablet) which should not be used in any production system yet.\n\nFixes #21572.\nJira: DB-10456\n\nTest Plan: `./yb_build.sh --cxx_test snapshot-schedule-test --gtest_filter=CloneFromScheduleTest.CloneAfterDrop`\n\nReviewers: mhaddad\n\nReviewed By: mhaddad\n\nSubscribers: ybase, bogdan\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D33922","shortMessageHtmlLink":"[#21572] docdb: Clone hidden tables from active rocksdb"}},{"before":"c36dd239cfd2b7863b91d4edf58e56a4767c823d","after":"7cb173c42ad39f00b1c0d6c6f621cc8542b613dd","ref":"refs/heads/master","pushedAt":"2024-04-26T03:22:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ddhodge","name":"Dwight Hodge","path":"/ddhodge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79169168?s=80&v=4"},"commit":{"message":"Update chapter2-scaling-with-yugabytedb.md","shortMessageHtmlLink":"Update chapter2-scaling-with-yugabytedb.md"}},{"before":"1fa2ee4339a030f499ce499ff2211a1acbc6250a","after":"c36dd239cfd2b7863b91d4edf58e56a4767c823d","ref":"refs/heads/master","pushedAt":"2024-04-26T00:14:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"myang2021","name":null,"path":"/myang2021","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/79478033?s=80&v=4"},"commit":{"message":"[#22139] YSQL: Fix PG crash when cluster has yb_debug_log_catcache_events=1\n\nSummary:\nTo reproduce the bug:\n\n./bin/yb-ctl create --rf 1 --tserver_flags=ysql_pg_conf_csv=yb_debug_log_catcache_events=1\n\n./bin/ysqlsh\n```\nysqlsh: could not connect to server: Connection refused\n Is the server running on host \"localhost\" (::1) and accepting\n TCP/IP connections on port 5433?\nFATAL: cannot read pg_class without having selected a database\n```\n\nI found that when MyDatabaseId is not resolved yet, there is a debugging code\nblock that is executed when yb_debug_log_catcache_events=1 cannot work\nproperly because it requires a database already selected. The debugging\ncode relies on other PG code to work and it failed at:\n\n```\nstatic HeapTuple\nScanPgRelation(Oid targetRelId, bool indexOK, bool force_non_historic)\n{\n HeapTuple pg_class_tuple;\n Relation pg_class_desc;\n SysScanDesc pg_class_scan;\n ScanKeyData key[1];\n Snapshot snapshot;\n\n /*\n * If something goes wrong during backend startup, we might find ourselves\n * trying to read pg_class before we've selected a database. That ain't\n * gonna work, so bail out with a useful error message. If this happens,\n * it probably means a relcache entry that needs to be nailed isn't.\n */\n if (!OidIsValid(MyDatabaseId))\n elog(FATAL, \"cannot read pg_class without having selected a database\");\n```\n\nFixed by adjusting the debug code so that when MyDatabaseId is invalid, we avoid\ncalling `YBDatumToString` which can trigger the PG FATAL.\n\nAfter the fix, the above simple test now succeeds, and the PG logs show debugging\nlogs like:\n\n```\n2024-04-25 23:37:25.762 UTC [27592] LOG: Catalog cache miss on cache with id 10:\n Target rel: pg_authid (oid : 1260), index oid 2676\n Search keys: typid=19 value=\n2024-04-25 23:37:25.762 UTC [27592] LOG: Catalog cache miss on cache with id 11:\n Target rel: pg_authid (oid : 1260), index oid 2677\n Search keys: typid=26 value=\n2024-04-25 23:37:25.885 UTC [27592] LOG: Catalog cache miss on cache with id 35:\n Target rel: pg_namespace (oid : 2615), index oid 2684\n```\nJira: DB-11064\n\nTest Plan: YB_EXTRA_TSERVER_FLAGS=\"--ysql_pg_conf_csv=yb_debug_log_catcache_events=1\" ./yb_build.sh release --cxx-test pg_catalog_version-test --gtest_filter PgCatalogVersionTest.DBCatalogVersion\n\nReviewers: jason\n\nReviewed By: jason\n\nSubscribers: yql\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34500","shortMessageHtmlLink":"[#22139] YSQL: Fix PG crash when cluster has yb_debug_log_catcache_ev…"}},{"before":"b64cac3dfb4e31c2057eb24076454daf4bb5715b","after":"1fa2ee4339a030f499ce499ff2211a1acbc6250a","ref":"refs/heads/master","pushedAt":"2024-04-26T00:09:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SeanSong25","name":"Xiaoyan Song","path":"/SeanSong25","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/76596926?s=80&v=4"},"commit":{"message":"[#20234] Metacache improvement: Refresh Meta-cache when successful RPC responds\n\nSummary:\nBackground:\nAs detailed in https://phorge.dev.yugabyte.com/D33533, the YBClient currently fails to update its meta-cache when there are changes in a raft group's configuration. This lapse can lead to inefficiencies such as persistent follower reads not recognizing the addition of closer followers. Consequently, even if there are suitable nearer followers, the system continues to rely on more distant followers as long as the RPCs are successful.\n\nSolution:\nThis update proposes enhancing RPC mechanisms (Read, Write, GetChanges, GetTransactionStatus) by appending the current raft_config_opid_index to each request. Upon receiving a request, if the raft_config_opid_index is outdated compared to the committed raft config opid index on the TabletPeer handling the request, the Tablet Server will include updated raft consensus state information in its response. This change aims to ensure that the meta-cache remains current, thus improving the system's efficiency in recognizing and utilizing the optimal server configurations for processing requests. This adjustment is part of a series of updates (alongside D33197 and D33598) designed to keep the meta-cache sufficiently current, thereby preventing the inefficiencies previously caused by outdated cache information. A flag enable_metacache_partial_refresh is added to turn the feature on, it is by default of right now.\n\nUpgrade/Rollback safety:\nThe additional field in the Response and Request Protobufs is temporary and will not be stored on disk, maintaining compatibility and safety during potential system upgrades or rollbacks.\nJira: DB-9194\n\nTest Plan:\nJenkins: urgent\nFull Coverage Testing:\nAdded a test flag FLAGS_TEST_always_return_consensus_Info_for_succeeded_rpc which will be turned on during debug mode. This flag will prompt the GetRaftConfigOpidIndex method on RemoteTablet to always return an OpId Index of value -2. So when the Tablet server is about to send back a successful response, it will find out that the request's piggybacked OpId index is stale, thus piggyback a TabletConsensusInfo to the response. When we receive the response in the aforementioned RPCs, if this flag is turned on, it will use a DCHECK to verify that if the RPC response can contain a TabletConsensusInfo and that the response was successful, then it must be the case that the TabletConsensusInfo exists in the response. This essentially allows us to leverage all the existing tests in the code base that exercises these RPCs to DCHECK our code path.\n\nUnit testing:\nAdded metacache_refresh_itest.cc, which contains the following tests:\nTestMetacacheRefreshFromFollowerRead:\n1. Sets up an external mini-cluster.\n2. Fills in the meta-cache by issuing a write op.\n3. Change the raft configuration of the tablet group by blacklisting a node and adding a node.\n4. Verify the next ConsistentPrefix read successfully refreshes meta-cache using a sync point.\n\nTestMetacacheNoRefreshFromWrite:\n1. Turns off the FLAGS_TEST_always_return_consensus_Info_for_succeeded_rpc\n2. Fills in the meta-cache by issuing a write op.\n3. Issue another write op and observe that no refresh happened.\n\nReviewers: mlillibridge, xCluster, hsunder\n\nReviewed By: mlillibridge\n\nSubscribers: bogdan, ybase, ycdcxcluster\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34272","shortMessageHtmlLink":"[#20234] Metacache improvement: Refresh Meta-cache when successful RP…"}},{"before":"24f8a2a32f490711372dc7f8e3c478e3f498501e","after":"b64cac3dfb4e31c2057eb24076454daf4bb5715b","ref":"refs/heads/master","pushedAt":"2024-04-26T00:04:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdbridge","name":"Mark","path":"/mdbridge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15827795?s=80&v=4"},"commit":{"message":"[#22161] DocDB: Gate new memory default recommendations on an ordinary gflag\n\nSummary:\nHere we introduce a new gflag:\n```\n~/code/yugabyte-db/src/yb/tserver/server_main_util.cc:36:\nDEFINE_NON_RUNTIME_bool(\n use_memory_defaults_optimized_for_ysql, false,\n \"If true, the recommended defaults for the memory usage settings take into account the amount \"\n \"of RAM and cores available and are optimized for using YSQL. \"\n \"If false, the recommended defaults will be the old defaults, which are more suitable \"\n \"for YCQL but do not take in account the amount of RAM and cores available.\");\n```\nto gate the new memory recommendations.\n\nMore precisely, we still have a concept of recommended defaults and individual memory settings can choose whether or not to use the recommended defaults. For example:\n```\n~/code/yugabyte-db/src/yb/tserver/tablet_memory_manager.cc:59:\n// NOTE: The default here is for tools and tests; the actual defaults\n// for the TServer and master processes are set in server_main_util.cc.\nDEFINE_NON_RUNTIME_int32(tablet_overhead_size_percentage, 0,\n \"Percentage of total available memory to use for tablet-related overheads. A value of 0 means \"\n \"no limit. Must be between 0 and 100 inclusive. Exception: \"\n BOOST_PP_STRINGIZE(USE_RECOMMENDED_MEMORY_VALUE) \" specifies to instead use a \"\n \"recommended value determined in part by the amount of RAM available.\");\n```\nIf this gflag is set to USE_RECOMMENDED_MEMORY_VALUE by the customer or left unset (the gflag default is set to that value for the TServer and master processes elsewhere), then we will use the recommended default for it.\n\nIf the new gflag is set to true then we use the new recommendations we have derived using our models. If it is set to false, then we use the same values we would've used prior to version 2024.1 if the customer had not provided a value for this gflag.\n\nThus, the customer gets essentially the same behavior as before 2024.1 if they do not set the new gflag.\nJira: DB-11090\n\nTest Plan:\nStarted cluster with and without flag on and look at logs:\n```\n~/code/yugabyte-db/bin/yb-ctl start\n\nI0425 10:52:25.180203 5935 server_main_util.cc:90] Setting flag db_block_cache_size_percentage to recommended value -3\nI0425 10:52:25.180212 5935 server_main_util.cc:92] Flag default_memory_limit_to_ram_ratio has value 0.65 (recommended value is 0.85)\nI0425 10:52:25.180217 5935 server_main_util.cc:94] Setting flag tablet_overhead_size_percentage to recommended value 0\n```\n\n```\nbin/yb-ctl start --tserver_flags \"use_memory_defaults_optimized_for_ysql=true\" \\\n --master_flag \"use_memory_defaults_optimized_for_ysql=true\"\n\nI0425 10:57:00.198920 6412 server_main_util.cc:101] Total available RAM is 31.183224 GiB\nI0425 10:57:00.198928 6412 server_main_util.cc:90] Setting flag db_block_cache_size_percentage to recommended value 32\nI0425 10:57:00.198938 6412 server_main_util.cc:92] Flag default_memory_limit_to_ram_ratio has value 0.65 (recommended value is 0.6)\nI0425 10:57:00.198943 6412 server_main_util.cc:94] Setting flag tablet_overhead_size_percentage to recommended value 10\n```\n(yb-ctl overrides default_memory_limit_to_ram_ratio.)\n\nReviewers: zdrudi\n\nReviewed By: zdrudi\n\nSubscribers: ybase\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34547","shortMessageHtmlLink":"[#22161] DocDB: Gate new memory default recommendations on an ordinar…"}},{"before":"2981a1ad043ebf9e4eefcf11512d6acbe7abdb50","after":"0234fbfdb52027099e8c19f1f0662a34e1f78a34","ref":"refs/heads/2024.1","pushedAt":"2024-04-25T23:40:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-13107] do not allow stable <-> preview comparisons in yba installer\n\nSummary:\nOriginal commit: 43e79b07d46f4465980988b1b13fa1b99e426f64 / D34440\nAs we move to the new release form of 2024.1, when comparing versions\nwe now want to block any comparison between a stable version (2.20 or 2024.1)\nand a preview version (2.17, 2.23)\n\nspecifically, we do not want to allow upgrades from one to the other\n\nTest Plan: new unit test\n\nReviewers: muthu, skurapati, sanketh\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34553","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-13107] do not allow stable <-> preview compari…"}},{"before":"d9ccf57933d8fff51f9488609368583bc590cd3a","after":"2981a1ad043ebf9e4eefcf11512d6acbe7abdb50","ref":"refs/heads/2024.1","pushedAt":"2024-04-25T23:05:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jharveysmith","name":"Jeff Harvey-Smith","path":"/jharveysmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6226895?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1]Allow yb_release to be called on unsupported platforms and exit nicely.\n\nSummary:\nOriginal commit: a01f61fd381f66bc6f5ab76240b6d48dd6db92d5 / D34296\nThis prevents us from having to track which platforms support which targets externally.\nOnce this is backported to all supported branches we can make changes to build jobs to call\nall targets all the time regardless of platform.\n\nTest Plan: Built locally\n\nReviewers: devops, sanketh, steve.varnau\n\nReviewed By: steve.varnau\n\nSubscribers: yugaware, devops\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34549","shortMessageHtmlLink":"[BACKPORT 2024.1]Allow yb_release to be called on unsupported platfor…"}},{"before":"413acf3bc93c5ec11e579ffe77d928b385c0bbb1","after":"d9ccf57933d8fff51f9488609368583bc590cd3a","ref":"refs/heads/2024.1","pushedAt":"2024-04-25T22:55:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][PLAT-13668] Create min_yba_verison.txt\n\nSummary:\nOriginal commit: a3ba2ecbd91dd153c28f3ef37d3d66cd09be5f5c / D34438\nFor now, we are symlinking the verson.txt from YBA, as it uses the\nsame versioning scheme as ybdb. Later, when YBA moves to 3.0.0 versioning, we may need to manually define the version\n\nTest Plan: build and validate min_yba_verison is populated in version.txt\n\nReviewers: muthu\n\nReviewed By: muthu\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34550","shortMessageHtmlLink":"[BACKPORT 2024.1][PLAT-13668] Create min_yba_verison.txt"}},{"before":"b0c73f4fed51b29835b0dae13a278cfc91f09775","after":"24f8a2a32f490711372dc7f8e3c478e3f498501e","ref":"refs/heads/master","pushedAt":"2024-04-25T22:46:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chidmuthu","name":"Muthu Chidambaram","path":"/chidmuthu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86024920?s=80&v=4"},"commit":{"message":"[PLAT-13708] Last backup time initialized during HA sync\n\nSummary: The fix https://phorge.dev.yugabyte.com/D34125 to sync remote configs removed the initialization of the local instance last backup time so subsequent updates were always null. This adds that line back in.\n\nTest Plan: Setup HA, ensure that lastBackupTime is displayed and shows up in HA config\n\nReviewers: dshubin, sanketh\n\nReviewed By: dshubin\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34554","shortMessageHtmlLink":"[PLAT-13708] Last backup time initialized during HA sync"}},{"before":"0ac8a65932ce0bbd5f510d592b143d4ce8e33785","after":"b0c73f4fed51b29835b0dae13a278cfc91f09775","ref":"refs/heads/master","pushedAt":"2024-04-25T22:28:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"shubin-yb","name":"Daniel Shubin","path":"/shubin-yb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/117757925?s=80&v=4"},"commit":{"message":"[PLAT-13570] Don't allow adding releases of a higher YBA version\n\nSummary:\na db release cannot be greater then the current yba\nversion, so check that in the api controllers.\n\nTest Plan: unit tests\n\nReviewers: muthu, anijhawan\n\nReviewed By: muthu\n\nSubscribers: yugaware\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34387","shortMessageHtmlLink":"[PLAT-13570] Don't allow adding releases of a higher YBA version"}},{"before":"0fb8883e6fd180a0e980549e80707ae9a5c91764","after":"413acf3bc93c5ec11e579ffe77d928b385c0bbb1","ref":"refs/heads/2024.1","pushedAt":"2024-04-25T21:37:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hari90","name":"Hari Krishna Sunder","path":"/hari90","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12418230?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#22054] xCluster UI: Group Inbound Replication Group tables by namespace and add table names\n\nSummary:\nOriginal commit: cb675c21e96892d5cd157af3f21f2d748dd7fe15 / D34293\nGroup the tables in the Inbound Replication Group of yb-master UI accoding to their namespaces.\nAdd Table names to both source and master UI views.\n\nCurrent Target output\n{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/973c4953-fb93-4733-88bb-e1395da8bbce , width=1000px}\n\nNew Target output\n{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/c33845ba-d429-4aa6-8962-5b6d7524f0f9 , width=1000px}\n\nCurrent Source output\n{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/b40d4695-37c2-4b96-a36b-2c62dd67024c , width=1000px}\n\nNew Source output\n{image uri=https://github.com/yugabyte/yugabyte-db/assets/12418230/a73bb2de-e3b3-485d-a3ed-3008b81024c2 , width=1000px}\n\nFixes #22054\nJira: DB-10972\n\nTest Plan: Jenkins\n\nReviewers: slingam, jhe, xCluster, yyan\n\nReviewed By: jhe\n\nSubscribers: xCluster, ybase, esheng\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34548","shortMessageHtmlLink":"[BACKPORT 2024.1][#22054] xCluster UI: Group Inbound Replication Grou…"}},{"before":"e0eea85acebe7d95cf89430f0de1bcd40f2433b4","after":"0ac8a65932ce0bbd5f510d592b143d4ce8e33785","ref":"refs/heads/master","pushedAt":"2024-04-25T21:36:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hari90","name":"Hari Krishna Sunder","path":"/hari90","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12418230?s=80&v=4"},"commit":{"message":"[#21540] xCluster: Add Repair APIs for DB Scoped replication\n\nSummary:\nAdding yb-admin commands:\n`repair_xcluster_outbound_replication_add_table `\n`repair_xcluster_outbound_replication_remove_table `\n\nThese will alow us to manually add or remove an individual table from the source side Outbound Replication Group.\n`repair_xcluster_outbound_replication_add_table` requires a stream_id which can be created using `bootstrap_cdc_producer`.\n`repair_xcluster_outbound_replication_remove_table` will not delete the xcluster stream. It will have to be manually deleted with `delete_cdc_stream`.\nNOTE: This is only meant for manual use by DevOps in extreme situations.\n\n**Upgrade/Rollback safety:**\nNew proto messages and APIs are guarded under `enable_xcluster_api_v2`\n\nFixes #21540\nJira: DB-10425\n\nTest Plan:\nXClusterOutboundReplicationGroupTest.Repair\nXClusterOutboundReplicationGroupTest.RepairWithYbAdmin\nXClusterDBScopedTest.DropTableOnProducerThenConsumer\nXClusterDBScopedTest.DropAllTables\nXClusterDBScopedTest.DisableAutoTableProcessing\n\nReviewers: jhe, slingam, xCluster\n\nReviewed By: jhe\n\nSubscribers: xCluster, ybase\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34239","shortMessageHtmlLink":"[#21540] xCluster: Add Repair APIs for DB Scoped replication"}},{"before":"352dad44dc1272be224efca32786d5709fe97340","after":"e0eea85acebe7d95cf89430f0de1bcd40f2433b4","ref":"refs/heads/master","pushedAt":"2024-04-25T21:30:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"premkumr","name":"Premkumar","path":"/premkumr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6393853?s=80&v=4"},"commit":{"message":"404 redirects (#22166)\n\n* 404 redirects\r\n\r\n* Apply suggestions from code review\r\n\r\nCo-authored-by: Aishwarya Chakravarthy \r\n\r\n---------\r\n\r\nCo-authored-by: Aishwarya Chakravarthy ","shortMessageHtmlLink":"404 redirects (#22166)"}},{"before":"dda33b441081e6bd87bdf4a55d91c453a6270eaf","after":"0fb8883e6fd180a0e980549e80707ae9a5c91764","ref":"refs/heads/2024.1","pushedAt":"2024-04-25T21:11:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jasonyb","name":null,"path":"/jasonyb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/93959687?s=80&v=4"},"commit":{"message":"[BACKPORT 2024.1][#21811] docdb: fix alma8 fastdebug gcc11 compilation\n\nSummary:\nCommit 061dc692f3db28772a8c3fa0a5cad11db1140301 introduces code causing\ncompilation failure\n\n ../../src/yb/integration-tests/cdcsdk_ysql_test_base.cc: In member function ‘void yb::cdc::CDCSDKYsqlTest::CheckRecordsConsistencyFromVWAL(const std::vector&)’:\n ../../src/yb/integration-tests/cdcsdk_ysql_test_base.cc:3879:9: error: ‘prev_op’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n 3879 | if (prev_op == RowMessage::DDL) {\n | ^~\n cc1plus: all warnings being treated as errors\n\nAlmalinux 8 + fastdebug + gcc11 is affected, but other build combos such\nas those in jenkins_jobs.yml are fine.\n\nFix the issue by initializing prev_op to UNKNOWN. This should be fine\naccording to the logic as far as I can tell.\nJira: DB-10712\n\nTest Plan:\nOn Almalinux 8:\n\n ./yb_build.sh fastdebug --gcc11\n\nClose: #21811\nOriginal commit: 193589f61ef5bcdc1f6b61eae052856339b0af3c / D33830\n\nReviewers: siddharth.shah\n\nReviewed By: siddharth.shah\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34494","shortMessageHtmlLink":"[BACKPORT 2024.1][#21811] docdb: fix alma8 fastdebug gcc11 compilation"}},{"before":"83ec5449d277145ba7871152e8e60252656d42b8","after":"9b21cc443aaf2b261bdf716dc899b75ce6633751","ref":"refs/heads/2.18","pushedAt":"2024-04-25T20:55:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chidmuthu","name":"Muthu Chidambaram","path":"/chidmuthu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86024920?s=80&v=4"},"commit":{"message":"[BACKPORT 2.18][PLAT-13683] Creating backup outside of HA causes a later HA promotion to fail\n\nSummary:\nOriginal commit: 3d9348ead4ad16b93a4659071aa0e9a276132412 / D34488\nWhen taking a backup with prometheus using the backup script or via yba-ctl the platform_dump.sql file is left behind because the trap is overriden by the prometheus specific code. If the backup was created with root then YBA process can't create a dump anymore as it tries to overwrite the dump file and HA replication fails. This diff adds explicit attempt to cleanup the backup file separate from the trap firing.\n\nTest Plan: Create yba-ctl backup with and without prometheus/releases, ensure platform_dump.sql file is cleaned up after the change.\n\nReviewers: dshubin, sanketh\n\nReviewed By: dshubin\n\nSubscribers: yugaware\n\nTags: #jenkins-ready\n\nDifferential Revision: https://phorge.dev.yugabyte.com/D34513","shortMessageHtmlLink":"[BACKPORT 2.18][PLAT-13683] Creating backup outside of HA causes a la…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEPKAstQA","startCursor":null,"endCursor":null}},"title":"Activity · yugabyte/yugabyte-db"}