Add tolerations to StatefulSet #28
Conversation
| {{- end }} | ||
| {{- if $root.Values.tolerations }} | ||
| tolerations: | ||
| {{ toYaml $root.Values.tolerations | indent 8 }} |
There was a problem hiding this comment.
This has to be unindented to make the | indent 8 work, apparently. Unsure if there's a better way to do it.
This is actually also kind of an issue for nodeSelector, but I think it would only show up if there are more than one label in the selector. If there's only one, the selector is visually overindented but still valid YAML:
spec:
nodeSelector:
# should be here...
# but is actually here
foo: bar
There was a problem hiding this comment.
You are right, good catch 😄 . AFAIK better would be to have something like this,
{{- if $root.Values.tolerations }}
tolerations:
{{- toYaml $root.Values.tolerations | nindent 8 }}
{{- end }}The hyphen before toYaml will remove one line (along with our indentation). The nindent will add a new line and then indent our object by 8.
Also, as you mentioned the nodeSelector needs to be fixed.
| {{- end }} | ||
| {{- if $root.Values.tolerations }} | ||
| tolerations: | ||
| {{ toYaml $root.Values.tolerations | indent 8 }} |
There was a problem hiding this comment.
You are right, good catch 😄 . AFAIK better would be to have something like this,
{{- if $root.Values.tolerations }}
tolerations:
{{- toYaml $root.Values.tolerations | nindent 8 }}
{{- end }}The hyphen before toYaml will remove one line (along with our indentation). The nindent will add a new line and then indent our object by 8.
Also, as you mentioned the nodeSelector needs to be fixed.
|
Along with the changes requested by @bhavin192 , could you please add a Test Plan to the commit summary with the helm command line used to test these changes? Thanks! |
Fixes #27