Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve query tracker liveness odin checks #563

Open
Krock21 opened this issue May 1, 2024 · 0 comments
Open

Improve query tracker liveness odin checks #563

Krock21 opened this issue May 1, 2024 · 0 comments
Assignees
@Krock21
Labels
query tracker YQL/query tracker related

Comments

@Krock21
Copy link
Member

Krock21 commented May 1, 2024 •
edited

Currently, if a query is running too long, we still try to read result and fail with Can't check query tracker with error: Query [query-id] result 0 not found or is expired

We need to:

  1. Provide a clear error message, that query wasn't able to finish in 30 seconds
  2. Add "partially available" state, when query finishes in A-B seconds
  3. Add ability to specify check timeout and soft timeout, as in map_result and sort_result odin checks
@Krock21 Krock21 added the query tracker YQL/query tracker related label May 1, 2024
@Krock21 Krock21 self-assigned this May 13, 2024
@Krock21 Krock21 mentioned this issue May 13, 2024
Closed
robot-piglet pushed a commit that referenced this issue May 16, 2024
@Krock21 @Krisha11 @robot-piglet
Improve Query Tracker odin checks with soft_timeout and error messages
357ffc2 
Issue: #563

Improve Query Tracker odin checks with soft_timeout and error messages

YQL query consists of 2 sequential operations: map and unordered merge. Map operation requires downloading 250mb file.

165 soft_query_timeout was formed by addition of 105s (`map_result` soft timeout) and 60s for unordered merge one
240 check_timeout was formed the same way (180s + 60s)

---
3a656ad9ab41cd023006038a10cafb3c71de5ecf

Pull Request resolved: #580

Co-authored-by: mpereskokova <mpereskokova@ytsaurus.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krock21 Krock21

Labels
query tracker YQL/query tracker related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Krock21