Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt functools.singledispatch to `coerce #150

Closed
wants to merge 1 commit into from
Closed

Adapt functools.singledispatch to `coerce #150

wants to merge 1 commit into from

Conversation

geonu
Copy link
Contributor

@geonu geonu commented Oct 26, 2019

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #150 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   96.98%   97.01%   +0.03%     
==========================================
  Files          14       14              
  Lines        1524     1541      +17     
==========================================
+ Hits         1478     1495      +17     
  Misses         46       46

@geonu
Copy link
Contributor Author

geonu commented Oct 26, 2019 •
edited

  • : Is singledispatch action like issubclass?
  • : Function Rename
  • : lru_cache

I will retry considering better design. Thx!

@geonu geonu closed this Oct 26, 2019
@youknowone
Copy link
Owner

After reviewing your patch, I think creating our own registry is better than signledispatch here.

there is a simple registry code here: https://github.com/youknowone/ring/blob/master/ring/coder.py#L66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support registry to coerce
2 participants
@geonu @youknowone