Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slickROutput(height = '50px') not respected #47

Open
DavorJ opened this issue Sep 2, 2020 · 3 comments
Open

slickROutput(height = '50px') not respected #47

DavorJ opened this issue Sep 2, 2020 · 3 comments

Comments

@DavorJ
Copy link

DavorJ commented Sep 2, 2020

Since the last version, the height parameter of slickROutput doesn't seem to work.

Here is an example:

image

The blue bounding box is 50px but as you see, the pictures are extended beyond it.

Workaround is to set '50px' in slickR(). But then, what is the point of height in slickROutput?

@yonicd
Copy link
Owner

yonicd commented Sep 2, 2020

Thanks for catching this. I'll look into it.

@yonicd
Copy link
Owner

yonicd commented Sep 4, 2020

You are correct. the way the underlying js code is written the widget size supersedes the container size it is in. to change this will take some refactoring. For the time being unfortunately you will have to control the size via the slickR function and not the output function.

@ismirsehregal
Copy link
Contributor

It seems that on the other hand the width argument is only taken into account when used in slickROutput not in slickR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants