Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility of 1.2.* where symfony/contracts also exists #157

Open
irinikp opened this issue Oct 5, 2020 · 1 comment
Open

Incompatibility of 1.2.* where symfony/contracts also exists #157

irinikp opened this issue Oct 5, 2020 · 1 comment

Comments

@irinikp
Copy link

irinikp commented Oct 5, 2020

If symfony/contracts is also used in the project, there versions 1.2.* have an issue:

TypeError : Argument 2 passed to Symfony\Component\EventDispatcher\EventDispatcher::dispatch() must be an instance of Symfony\Component\EventDispatcher\Event or null, instance of Finite\Event\StateMachineEvent given

This seems to occur when someone has both the Symfony\Contracts\EventDispatcher\Event and Symfony\Component\EventDispatcher\Event installed. This check in StateMachineEvent checks whether Symfony\Contracts\EventDispatcher\Event exists, and aliases it to Symfony\Component\EventDispatcher\Event if not.

@irinikp
Copy link
Author

irinikp commented Oct 5, 2020

Submitted PR to resolve this issue #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant