Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add data property to Event #57

Open
juanmiguelbesada opened this issue Aug 22, 2019 · 1 comment
Open

[FEATURE] Add data property to Event #57

juanmiguelbesada opened this issue Aug 22, 2019 · 1 comment

Comments

@juanmiguelbesada
Copy link

Hi all!

I'm working with this library for a while (It works like a charm BTW), and I really missing what I think is a good new feature.

The default Event model, does not have the possibility to hold a "data" (Where data is whatever you need, it could be an object, an array or a primitive), and you always have to extend default Entity to include your custom data.

While i think this is good for advanced use cases, i think for simple use cases, having a "bag" where store whatever you need (a title, a status, or even an array with more complex data) without having to extend the default model would be perfect.

I don't know what you think, if you agree I can work on a pull request.

Thanks you for your work

@peter279k
Copy link

Hi, thank you for your reply.

If possible, you can just submit the PR and wait for @yohang to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants