Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Replace underscore in header-name with dash #137

Open
leberknecht opened this issue Jun 14, 2023 · 0 comments
Open

[Feature] Replace underscore in header-name with dash #137

leberknecht opened this issue Jun 14, 2023 · 0 comments

Comments

@leberknecht
Copy link

While i'm aware that underscores are totally legal in header-names, a lot of libs / software doesnt play well with it (nginx for example requires to explicitly allow them via underscores_in_headers on; ..for whatever reason. Also symfonys BrowserKit component replaces the underscore with a dash, and there are more examples like that).

While this is not yobulks fault, i still think that, for broader adaption, it would make sense to change the header template_id to template-id (or even Template-Id maybe?) as that is simply more-common.

Opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant