Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: transcode color spaces deleting unprocessed representations #6255

Open
antirotor opened this issue Mar 27, 2024 · 2 comments
Open

Bug: transcode color spaces deleting unprocessed representations #6255

antirotor opened this issue Mar 27, 2024 · 2 comments
Assignees
Labels
port to AYON type: bug Something isn't working

Comments

@antirotor
Copy link
Member

antirotor commented Mar 27, 2024

Transcode color spaces plugin (extract_color_transcode.py or Extract OIIO Transcode in the Settings) delete representation triggers for any representation matching its conditions even when it is not processed by it (no transcoding is happening).

@antirotor antirotor added type: bug Something isn't working port to AYON labels Mar 27, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Mar 27, 2024

_repre_is_valid() is returning True/False so this condition will not trigger for False values.

Sorry, what?

I don't really understand what you're saying. It returning False or True is perfectly fine - right?

expecting return value None is getting bool

Why do you feel like it's expecting a None value? The python if and if not works perfectly fine for booleans.

@antirotor
Copy link
Member Author

_repre_is_valid() is returning True/False so this condition will not trigger for False values.

Sorry, what?

I don't really understand what you're saying. It returning False or True is perfectly fine - right?

expecting return value None is getting bool

Why do you feel like it's expecting a None value? The python if and if not works perfectly fine for booleans.

Right, morning fatigue. It is actually happening because of wrong nesting of loops. _repre_is_valid() will skip the processing in first loop, but not in the next that is removing representations.

@antirotor antirotor changed the title Bug: transcode color spaces using wrong logic Bug: transcode color spaces deleting unprocessed representations Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port to AYON type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants