Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: host specific Deadline plugins crashing outside their context #6133

Open
2 tasks done
antirotor opened this issue Jan 15, 2024 · 1 comment
Open
2 tasks done
Labels
module: Deadline AWS Deadline related features type: bug Something isn't working

Comments

@antirotor
Copy link
Member

antirotor commented Jan 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

Host specific deadline plugins are registered even outside their respective hosts. Because of their top-level imports of host API, they crash - silently because pyblish will just log crashing plugin but won't stop running.

Expected Behavior:

We should move host specific plugins to their respective folders and these folders only inside the host. That will clear up the log, speed discovery a little bit and also avoid a lot of confusion when debugging failed publishes.

As a next step, we should change the pyblish logic not to skip crashing plugin with some transition period.

Version

3.18.4-nightly.1

What platform you are running OpenPype on?

Windows

Steps To Reproduce:

Publish something in Nuke with Deadline addon enabled
You'll see some crashed plugins in Crashed Plugins log.

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

No response

Additional context:

No response

[cuID:OP-7976]

@antirotor antirotor added type: bug Something isn't working module: Deadline AWS Deadline related features labels Jan 15, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Jan 15, 2024

Most of these were resolved recently by moving the imports, but one import was missed for the maya plug-in (RenderSettings import).
However, I would really like it actually if the Deadline module would only install host specific plug-ins if it is inside that host. That would likely mean having a host specific subfolder in Deadline module plugins/publish like:

plugins/publish/maya
plugins/publish/houdini

Which then get registered maybe in the Addon in on_host_install. Thoughts?

If you agree - I can try and make this change quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: Deadline AWS Deadline related features type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants