Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID Connect group claim support #337

Open
azmeuk opened this issue Oct 21, 2021 · 4 comments
Open

OpenID Connect group claim support #337

azmeuk opened this issue Oct 21, 2021 · 4 comments
Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement

Comments

@azmeuk
Copy link
Contributor

azmeuk commented Oct 21, 2021

I suggest reading the groups a user belongs to from a group claim in the user JWT.
There is currently no standard around a OIDC group claim, but this can be done with a configuration parameter to chose which claim should be used. This is how nextcloud-oidc-login handles it, for instance.

What do you think? Would you accept such a patch?

@samdark
Copy link
Member

samdark commented Oct 21, 2021

How standard is it? Any use-cases other than nextcloud?

@azmeuk
Copy link
Contributor Author

azmeuk commented Oct 21, 2021

nextcloud-oidc-login is not a usecase for yii, it is an example of a OIDC client that handles a group claim.

There is no actual standard (RFC or whatever) but a strong convention among the OIDC players. However as there is no standard, the different identity providers use different claims to communicate the groups a user belongs to. This is why I suggest adding a configuration option so one can choose the right claim in which to read the user groups.

@samdark samdark added status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement and removed status:under discussion labels Oct 21, 2021
@samdark
Copy link
Member

samdark commented Oct 21, 2021

Sounds alright. Have time for a pull request?

@azmeuk
Copy link
Contributor Author

azmeuk commented Oct 21, 2021

Not in a near future, but I would be OK to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants