Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title label no longer in the code #242

Open
newscloud opened this issue Aug 27, 2018 · 0 comments
Open

Title label no longer in the code #242

newscloud opened this issue Aug 27, 2018 · 0 comments
Labels
status:to be verified Needs to be reproduced and validated. type:bug Bug

Comments

@newscloud
Copy link

newscloud commented Aug 27, 2018

What steps will reproduce the problem?

Upgraded to 2.1 using composer

What's expected?

previously a text label visually appeared below each icon

What do you get instead?

only the icons

Additional info

Here was the old code that was generated
<div id="w0" class="auth-clients"><ul class="auth-clients clear"><li class="auth-client"><a class="google auth-link" href="/site/auth?mode=signup&amp;authclient=google"><span class="auth-icon google"></span><span class="auth-title">Google</span></a></li><li class="auth-client"><a class="facebook auth-link" href="/site/auth?mode=signup&amp;authclient=facebook"><span class="auth-icon facebook"></span><span class="auth-title">Facebook</span></a></li><li class="auth-client"><a class="linkedin auth-link" href="/site/auth?mode=signup&amp;authclient=linkedin"><span class="auth-icon linkedin"></span><span class="auth-title">LinkedIn</span></a></li></ul></div>
The visible label is generated by the html
<span class="auth-title">Facebook</span>

AuthChoice.php has code in clientclink to generate the auth-icon
$text = Html::tag('span', '', ['class' => 'auth-icon ' . $client->getName()]);
but there's no code to generate auth-title
although it is defined in the css

Q A
Yii version 2.0.15
Yii Auth Client version 2.1.5
Yii HTTP Client version
PHP version 7.x
Operating system
@newscloud newscloud changed the title Title label no long in the code Title label no longer in the code Aug 27, 2018
@machour machour added type:bug Bug status:to be verified Needs to be reproduced and validated. labels Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:to be verified Needs to be reproduced and validated. type:bug Bug
Projects
None yet
Development

No branches or pull requests

2 participants