Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are slower than linear_map::LinearMap and heapless::LinearMap #71

Open
yegor256 opened this issue Apr 25, 2023 · 2 comments
Open

We are slower than linear_map::LinearMap and heapless::LinearMap #71

yegor256 opened this issue Apr 25, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@yegor256
Copy link
Owner

yegor256 commented Apr 25, 2023

According to our benchmark, we are slower than linear_map::LinearMap when map size is bigger than 5, but we shouldn't be, since we use the same algorithm as they do. They use Vec, while we manage our own array. Let's investigate and fix.

@yegor256 yegor256 added bug Something isn't working help wanted Extra attention is needed labels Apr 25, 2023
@yegor256 yegor256 changed the title We are slower than linear_map::LinearMap We are slower than linear_map::LinearMap and heapless::LinearMap May 27, 2023
@yegor256
Copy link
Owner Author

yegor256 commented Jan 1, 2024

@alexkazik we can close this one, I believe?

@alexkazik
Copy link
Contributor

The benchmark here has improved, yes. Though when running it locally (arm64) it's not that a big improvement (and very different to yours to begin with).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants