Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete non-UTF8 source Java files #169

Closed
yegor256 opened this issue Feb 26, 2024 · 7 comments
Closed

delete non-UTF8 source Java files #169

yegor256 opened this issue Feb 26, 2024 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@yegor256
Copy link
Owner

No description provided.

@timur-harin
Copy link
Contributor

I started working on this problem

@timur-harin timur-harin mentioned this issue Feb 27, 2024
Closed
@timur-harin
Copy link
Contributor

@yegor256
In PR I completed deletion not UTF8 source Java files

I think that we need also to have this script with showing which files were deleted which I put in the help folder

@timur-harin
Copy link
Contributor

The using of this script is shown here
Screenshot 2024-02-27 at 19 30 33

The correct one with utf8 is here
Screenshot 2024-02-27 at 19 32 40

@timur-harin
Copy link
Contributor

timur-harin commented Mar 5, 2024 •
edited

@yegor256 I updated a PR with test and right position of script

@yegor256 yegor256 added the help wanted Extra attention is needed label Apr 14, 2024
@padjal padjal mentioned this issue Apr 18, 2024
Merged
@padjal
Copy link
Contributor

padjal commented Apr 18, 2024

@yegor256 I have created a PR for this issue.

@padjal
Copy link
Contributor

padjal commented Apr 21, 2024

@yegor256 Since we have successfully merged PR #285 - Add delete wrongly encoded files, which solves this problem, I think that we can close this issue as well.

@padjal
Copy link
Contributor

padjal commented May 3, 2024

@yegor256 PR#285 with changes which solve this issue has been successfully merged. Please close this issue.

@yegor256 yegor256 closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @padjal @timur-harin