Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joined(Iterable<? extends T> items, T item) #1619

Open
yegor256 opened this issue Jun 22, 2021 · 7 comments
Open

Joined(Iterable<? extends T> items, T item) #1619

yegor256 opened this issue Jun 22, 2021 · 7 comments

Comments

@yegor256
Copy link
Owner

How about we introduce a new ctor Joined(Iterable<? extends T> items, T item), which will add the item to the end of the list. Currently, the existing ctor Joined(T item, Iterable<? extends T> items) prepends the list with a new item. I didn't manage to find how to append it.

@victornoel
Copy link
Collaborator

@yegor256 to append it you can use something like: new Joined(items, new IterableOf(item)) but I agree we can indeed add a constructor for this use case.
I would generify it by proposing we introduce Joined(Iterable<? extends T> items, T... appended)

@victornoel
Copy link
Collaborator

@0crat in

2 similar comments
@victornoel
Copy link
Collaborator

@0crat in

@victornoel
Copy link
Collaborator

@0crat in

@william7b7d
Copy link

I can pick this one up. Seems like a good first contribution. Do you all have contributor guidelines anywhere? Looks like there's a qulice profile that will run a code style check.

@victornoel
Copy link
Collaborator

@william7b7d yep, you can make a PR and we will review it. qulice will be executed automatically. If you have doubts about what needs to be done, don't hesitate to ask here first!

@william7b7d
Copy link

Okay got a PR together. Let me know if I missed anything.

#1705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants