Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise function names to match geointerface #377

Open
rafaqz opened this issue Apr 24, 2023 · 0 comments
Open

Standardise function names to match geointerface #377

rafaqz opened this issue Apr 24, 2023 · 0 comments

Comments

@rafaqz
Copy link
Collaborator

rafaqz commented Apr 24, 2023

Seeing we need to call the internal methods to run them on non-ArchGDAL geometries (there is no way to dispatch using the GeoInterface.jl methods), it would be nice if they were all identical to GeoInterface.jl syntax. Then LibGEOS and everything else should do the same.

This means AG.area rather than AG.geomarea, AG.astext rather than AG.toWKT, and most unfortunately AG.length instead of AG.geomlength. We can also just keep both functions.

length will be a pain because we will need to use Base.length everywhere else in the package.

See #366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant