Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scroll bar? #229

Open
austinthresher opened this issue Jun 7, 2022 · 6 comments
Open

Disable scroll bar? #229

austinthresher opened this issue Jun 7, 2022 · 6 comments

Comments

@austinthresher
Copy link

I've looked around but haven't been able to find a way to disable the scrollbar. Is there an option for this? If not, it would be a welcome addition. It's honestly one of the main annoyances preventing me from using this as my main nvim frontend.

@luxus
Copy link
Contributor

luxus commented Aug 15, 2022

Same here, Fvim looks great with all the remote functionality. but the unthemed scrollbar (it's on the screenshots in the README.md) on linux/macos is really a dealbreaker
@yatli any plans to implement it?

@yatli
Copy link
Owner

yatli commented Aug 15, 2022

E_BUSY

Comment out these:

fvim/Views/Grid.xaml.fs

Lines 458 to 459 in b836b56

if not (vm.IsMsg || vm.IsFloat) then
drawScrollbar()

PRs are welcome!

@luxus
Copy link
Contributor

luxus commented Aug 15, 2022

doesn't work. still shows a scrollbar

diff --git a/Views/Grid.xaml.fs b/Views/Grid.xaml.fs
index 77492d5..e368695 100644
--- a/Views/Grid.xaml.fs
+++ b/Views/Grid.xaml.fs
@@ -455,8 +455,8 @@ type Grid() as this =
           m_gadget_brush.Color <- color
           m_gadget_brush.Opacity <- 1.0
           ctx.FillRectangle(m_gadget_brush, Rect(sx, sy, sign_w, sign_h))
-    if not (vm.IsMsg || vm.IsFloat) then
-      drawScrollbar()
+    // if not (vm.IsMsg || vm.IsFloat) then
+    //  drawScrollbar()
 
     let drawDebug() =
       let txt = Media.FormattedText()

@yatli
Copy link
Owner

yatli commented Aug 15, 2022

stale binary?

that should be the only entrance to scrollbar drawing routine.

@luxus
Copy link
Contributor

luxus commented Aug 15, 2022

@yatli
Copy link
Owner

yatli commented Aug 15, 2022

ha I see. you two are talking about different things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants