From d142a4308bbec452a9cfef3b3f74685ddd34b170 Mon Sep 17 00:00:00 2001 From: Yasuharu Ozaki Date: Sun, 31 Jan 2016 16:59:06 +0900 Subject: [PATCH] Remove redundant maxValue calculation --- Source/YOChartImageKit/YOBarChartImage.m | 2 +- Source/YOChartImageKit/YOLineChartImage.m | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/YOChartImageKit/YOBarChartImage.m b/Source/YOChartImageKit/YOBarChartImage.m index d4c10d0..797d365 100644 --- a/Source/YOChartImageKit/YOBarChartImage.m +++ b/Source/YOChartImageKit/YOBarChartImage.m @@ -26,7 +26,7 @@ - (NSNumber *) maxValue { - (UIImage *)drawImage:(CGRect)frame scale:(CGFloat)scale { NSAssert(_values.count > 0, @"YOBarChartImage // must assign values property which is an array of NSNumber"); - CGFloat maxValue = _maxValue ? [_maxValue floatValue] : [[_values valueForKeyPath:@"@max.floatValue"] floatValue]; + CGFloat maxValue = self.maxValue.floatValue; CGFloat dataCount = (CGFloat)_values.count; CGFloat padding; diff --git a/Source/YOChartImageKit/YOLineChartImage.m b/Source/YOChartImageKit/YOLineChartImage.m index 9317ada..92b19df 100644 --- a/Source/YOChartImageKit/YOLineChartImage.m +++ b/Source/YOChartImageKit/YOLineChartImage.m @@ -22,7 +22,7 @@ - (UIImage *)drawImage:(CGRect)frame scale:(CGFloat)scale { NSUInteger valuesCount = _values.count; CGFloat pointX = frame.size.width / (valuesCount - 1); NSMutableArray *points = [NSMutableArray array]; - CGFloat maxValue = _maxValue ? [_maxValue floatValue] : [[_values valueForKeyPath:@"@max.floatValue"] floatValue]; + CGFloat maxValue = self.maxValue.floatValue; [_values enumerateObjectsUsingBlock:^(NSNumber *number, NSUInteger idx, BOOL *_) { CGFloat ratioY = number.floatValue / maxValue;