Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class DQN uses global variable in assert #494

Open
DIPOON opened this issue May 4, 2022 · 0 comments
Open

class DQN uses global variable in assert #494

DIPOON opened this issue May 4, 2022 · 0 comments

Comments

@DIPOON
Copy link

DIPOON commented May 4, 2022

Hello. I'm just student.
I'm not good at English so Excuse me first.

In https://github.com/yandexdataschool/Practical_RL/blob/master/week04_approx_rl/homework_pytorch_main.ipynb, class DQNAgent's forward uses n_actions of global variables as following.
"assert len(
qvalues.shape) == 2 and qvalues.shape[0] == state_t.shape[0] and qvalues.shape[1] == n_actions"
I guess assert should use class private variables
assert len(
qvalues.shape) == 2 and qvalues.shape[0] == state_t.shape[0] and qvalues.shape[1] == **self.**n_actions
It's not important I know.
Just want to check whether my thought is ok...

Thank you!
If you need, tell me my e-mail : 6129876j@naver.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant