Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Theano/Lasagne support #258

Closed
dniku opened this issue Aug 25, 2019 · 0 comments · Fixed by #348 or #485
Closed

Remove Theano/Lasagne support #258

dniku opened this issue Aug 25, 2019 · 0 comments · Fixed by #348 or #485
Assignees

Comments

@dniku
Copy link
Collaborator

dniku commented Aug 25, 2019

It is hard to maintain support for 3 frameworks (Theano/Lasagne, TF, PyTorch). Since Theano/Lasagne are the oldest ones and have very little traction in the community today, after a discussion with @justheuristic we have decided to remove support for them entirely.

Here is a complete list of files that refer to Theano or Lasagne, obtained via git grep -l -i 'theano\|lasagne'. Legend:

. false positive
~ to be edited
x to be deleted
~ Amazon GPU howto.md
~ Dockerfile
~ docker/Dockerfile
~ week04_[recap]_deep_learning/README.md
~ week04_[recap]_deep_learning/fix_my_nn.ipynb
. week04_[recap]_deep_learning/mnist.py
x week04_[recap]_deep_learning/practice_lasagne.ipynb
. week04_[recap]_deep_learning/seminar_pytorch.ipynb
x week04_approx_rl/homework_lasagne.ipynb
x week04_approx_rl/seminar_lasagne.ipynb
~ week05_explore/README.md
~ week05_explore/bayes.py
~ week05_explore/week5.ipynb
~ week06_policy_based/README.md
x week06_policy_based/reinforce_lasagne.ipynb
~ week06_policy_based/reinforce_tensorflow.ipynb
~ week07_[recap]_rnn/README.md
. week07_[recap]_rnn/arxiv_data.csv
x week07_[recap]_rnn/seminar_lasagne.ipynb
x week07_[recap]_rnn/seminar_lasagne_ingraph.ipynb
~ week07_seq2seq/README.md
x week07_seq2seq/basic_model_theano.py
. week07_seq2seq/basic_model_torch.py
~ week07_seq2seq/bonus.ipynb
. week07_seq2seq/main_dataset.txt
x week07_seq2seq/practice_theano.ipynb
~ week08_pomdp/atari_util.py
~ week08_pomdp/homework_common_part2.ipynb
x week08_pomdp/practice_theano.ipynb
x week08_pomdp/theano_optional_recurrence_tutorial.ipynb
~ week09_policy_II/README.md
x week09_policy_II/seminar_TRPO_theano.ipynb
~ youtube_dl_lectures.sh

week04_[recap]_deep_learning/fix_my_nn.ipynb should have a PyTorch/TF translation elsewhere (DL course?).

Migrating week05 to PyTorch/TF is #174. It is probably going to be easier if that issue is implemented first.

@dniku dniku pinned this issue Apr 16, 2020
@yhn112 yhn112 self-assigned this May 11, 2020
@yhn112 yhn112 linked a pull request May 11, 2020 that will close this issue
@dniku dniku reopened this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants