Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SCSS in file _hlist.scss #54

Open
martinschaible opened this issue Aug 21, 2014 · 5 comments
Open

Bug: SCSS in file _hlist.scss #54

martinschaible opened this issue Aug 21, 2014 · 5 comments

Comments

@martinschaible
Copy link

Line 53:

&.active {
should be:
&.active a {

@MacKP
Copy link

MacKP commented Aug 21, 2014

&.active is OK here. The a element is styled after line 59. This selector is in CSS -> .ym-hlist ul li.active

@martinschaible
Copy link
Author

If you compare the normal CSS-file for the navigation with the SCSS variant, you will see the difference.
I had to update the file like I described to get it work.

michsch added a commit to michsch/yaml that referenced this issue Aug 21, 2014
@MacKP
Copy link

MacKP commented Aug 22, 2014

I can't see your point. In the hlist.css on line 61 is this selector -> '.ym-hlist ul li.active'
This doesn't look like '.ym-hlist ul li.active a' for me. And all the selectors after that can't work with your &.active a.

@djesse
Copy link
Contributor

djesse commented Aug 22, 2014

If you compare the normal CSS-file for the navigation with the SCSS variant, you will see the difference. I had to update the file like I described to get it work.

The normal CSS is compiled from the SASS source, so there can't be a difference in meaning of selectors. What's the problem with the current solution?

@michsch
Copy link
Member

michsch commented Aug 24, 2014

@djesse @martinschaible There is no actual "problem" with the existing stylesheet (http://codepen.io/michsch/pen/dKeEv), but it's not straight to use background and font color for the a-selector and a few lines further for the li.active (parent) selector, or am i wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants