Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include 'deletable' property with EdgeProps and NodeProps #4269

Open
TimmyTango opened this issue May 9, 2024 · 1 comment
Open

Include 'deletable' property with EdgeProps and NodeProps #4269

TimmyTango opened this issue May 9, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@TimmyTango
Copy link

TimmyTango commented May 9, 2024

Please describe the feature that you want to propose

The deletable property exists on Nodes and Edges, but isn't exposed to NodeProps and EdgeProps. This means you can't use the deletable property for conditional rendering for Node and Edge types.

In my specific case, I want to hide the delete icon I normally show on Edges in my EdgeType if deletable is false. I tried to access deletable anyway, hoping it was just at the type level, but it's always undefined.

As a workaround, I'm adding my own deletable property in my Edge's data property.

@TimmyTango TimmyTango added the feature request New feature or request label May 9, 2024
@TimmyTango TimmyTango changed the title Add 'deletable' property to EdgeProps and NodeProps types Expose 'deletable' property to EdgeProps and NodeProps May 9, 2024
@TimmyTango TimmyTango changed the title Expose 'deletable' property to EdgeProps and NodeProps Include 'deletable' property with EdgeProps and NodeProps May 10, 2024
@peterkogo
Copy link
Member

Thanks for bringing this up! That actually is a viable use case. I will open a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants