Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error conforming to net.Error for timeouts #76

Closed
wants to merge 2 commits into from
Closed

Return error conforming to net.Error for timeouts #76

wants to merge 2 commits into from

Conversation

forkner
Copy link

@forkner forkner commented Jul 23, 2020

Fixes #75

@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited

Codecov Report

Merging #76 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   83.05%   83.12%   +0.07%     
==========================================
  Files           6        6              
  Lines         708      711       +3     
==========================================
+ Hits          588      591       +3     
  Misses        100      100              
  Partials       20       20
Impacted Files Coverage Δ
session.go 79.27% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f718802...05ac7f9. Read the comment docs.

@forkner forkner closed this Jul 23, 2020
@forkner forkner reopened this Jul 23, 2020
@forkner forkner mentioned this pull request Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream does not return net.Error for timeouts
1 participant
@forkner