feat(report): use Oxygen styling and add alert about failures #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the diff of the CSS between Oxygen 19 and 20, I looked for /* Oxygen */ and things commented out only in Oxygen 19. I also pasted in styles from the end of the Oxygen 19 file but before some new-ish styles from the XSpec version of the file.
Compensate for the fact that less shading in the report makes the difference between zero failures and nonzero failures less obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges CSS styles coming from Oxygen 19 with the existing CSS styles from this repo's master branch. Thanks to @AlexJitianu and the rest of the Oxygen team for creating those styles and letting us use them in this repo!
As I mentioned in my comments in #92, I feel that the reduced shading is a step backward in the ease of distinguishing at a glance between some failures and no failures. To compensate, this pull request adds an "alert" line near the top of the report when there is at least one failure. I'm open to feedback about other ways to compensate.
Resolves #92
Resolves #919