Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mozilla Public License #1786

Open
AirQuick opened this issue Oct 5, 2023 · 4 comments
Open

Remove Mozilla Public License #1786

AirQuick opened this issue Oct 5, 2023 · 4 comments
Milestone

Comments

@AirQuick
Copy link
Member

AirQuick commented Oct 5, 2023

https://github.com/xspec/xspec/tree/master/java/com/jenitennison/xslt/tests is under the Mozilla Public License.

The reason I guess is that Jeni started the code from one of the Saxon source code files which originally was contributed by Edwin Glaser. If we remove the remnant of the original code (mostly comments, I guess) and get Jeni's approval, we're probably allowed to change its license to MIT.

(Also we may want to change its namespace from com.jenitennison.xslt.tests to io.xspec.xspec.saxon.something.)

@AirQuick AirQuick added this to the v3.0 milestone Oct 5, 2023
@AirQuick
Copy link
Member Author

AirQuick commented Oct 5, 2023

the remnant of the original code (mostly comments, I guess)

Indeed, comparing these files, the original Mozilla Public License portion appears to be, essentially, only comments.

@galtm
Copy link
Collaborator

galtm commented Nov 29, 2023

@JeniT : do you have any comments on this issue?

@JeniT
Copy link

JeniT commented Nov 29, 2023

I don't have any objections to changing the licence or the namespace :)

@galtm
Copy link
Collaborator

galtm commented Mar 21, 2024

@JeniT : Thanks for your reply.

@AirQuick : Did you have in mind something like the following?

  1. In the Java source file, remove the comments that Jeni didn't change between the Saxon 9.2.1.2 TraceListener.java file and her initial commit of the XSLTCoverageTraceListener.java file.
  2. Change the set of comments at the bottom of the file to something that gives credit without asserting the Mozilla license. Perhaps something like the block of code below
  3. In README.md at the top of this repo, remove the sentence that mentions the Mozilla license.
// This file is part of the XSpec repository, github.com/xspec/xspec.
//
// Development credits:
// - Methods implemented by Jeni Tennison
// - Extended for Saxon 9.7 by Sandro Cirulli, github.com/cirulls
// - Extended for Saxon 12.4 by AirQuick, github.com/AirQuick
//
// Portions created by Jeni Tennison are Copyright (C) Jeni Tennison.
// All Rights Reserved.
//
// This file was inspired by net/sf/saxon/trace/TraceListener.java
// in Saxon 9.2.1.2. That file was developed by Edwin Glaser and
// heavily modified by Michael Kay.

Cc: @xspec/xspec to keep others informed and in case anyone else has advice or opinions.

@galtm galtm mentioned this issue Mar 24, 2024
17 tasks
@galtm galtm modified the milestones: v3.0, v3.1 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants