-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PipeTable invalid rendering #744
Comments
Facing the same problem on Windows. Could make a workaround on saving markdown documents in "LF" instead of Windows default "CRLF". Therefore seems to be a line-ending problem on Windows which markdig isn't capable of. |
At which moment do you do that? I was trying to save the original file LF like you said as below, but didnt help. |
For me during testing it worked saving the file as LF via Visual Studio Code. That's our workaround currently to be able to use pipetables. |
What version of Markdig do you use and what is a target of build/configuration on which you run? |
Same applies to me, using markdig 0.33.0, running Windows 11. |
If you're creating a renderer yourself, you must configure it with the pipeline you're using. var renderer = new RoundtripRenderer(sw);
+pipeline.Setup(renderer); Otherwise, the renderer won't know what to do with the syntax objects describing the table. Also, note that |
@pburndorfer can you please open a new issue describing the problems you are running into w.r.t. new lines? |
I see that you render it into HTML, not back to Markdown. |
@MihaZupan |
The parsing of tables isn't that basic though. |
To clarify what @MihaZupan explained, there was a tentative of writing a Then someone made a large PR #481 that brought roundtrip parsing and renderer. It is a lot more complicated to bring such feature and the original PR made it "only" for the core part of CommonMark. Most of the extensions are not supported by roundtrip. Implementing support for them can be a significant amount of work (and can be quite challenging technically), so if you need such feature, expect that you will have to bring that support and it will take lots of time. |
@xoofx @MihaZupan |
That's not how usually contributors interact with GitHub projects. You need to create a fork of this repo, create a branch in your fork, create/push commits and then once you are ready you can open a pull request. |
Hi,
Given table is rendered as below.
The text was updated successfully, but these errors were encountered: