Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and tests #5

Open
mjablecnik opened this issue Sep 12, 2021 · 1 comment
Open

Refactoring and tests #5

mjablecnik opened this issue Sep 12, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mjablecnik
Copy link

Hello @xnbox I found your DeebfakeHTTP project here and it looks very nice 馃憤
You created nice tool with good documentation and probably I will be use it ;-)

But when I look into your code so I can really recommend you to read Clean Code book by Robert C. Martin.
Because I found that you need it.

Then I really recommend you to go through your projects and made refactor because in DeepfakeHttpServlet you have very big doDbRequest function which can be splited into more smaller functions for better readability.
I tried understand it for future contribution but it is very hard to read and understand for me..

The same you can make also in your other projects for example BrowserWindow.java intommybox project you have really big launch function or createMenu function..

Also you should create some tests for ensure that after your refactor works everything right.

Without this changes will be very hard for other developers like me to understand your code and make some changes and PRs in the future..

I hope it will be improved and your project will be successful in the Open Source world. ;-)

@xnbox
Copy link
Owner

xnbox commented Sep 13, 2021

Hi Martin, thanks for the thoughtful code reading and your advice!
You're certainly right, doDbRequest is too complex and performs several functions at once, which is not good.
The same applies to BrowserWindow.java
Your remarks motivate me to refactor this code!
I put it on my TODO list. 馃憤
And yes, I will definitely add tests!
Thank you!

@xnbox xnbox self-assigned this Sep 13, 2021
@xnbox xnbox added the enhancement New feature or request label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants